swift-proxy charm uses old keystonemiddleware config

[Corey Bryant]

ubuntu@juju-2b302b-zaza-8d2bffc075ea-4:~$ systemctl status swift-proxy
● swift-proxy.service - OpenStack Swift proxy server
     Loaded: loaded (/lib/systemd/system/swift-proxy.service; enabled; vendor preset: enabled)
     Active: active (running) since Mon 2022-02-14 21:19:06 UTC; 32min ago
       Docs: man:swift-proxy-server(1)
   Main PID: 23229 (swift-proxy-ser)
      Tasks: 3 (limit: 2339)
     Memory: 99.8M
     CGroup: /system.slice/swift-proxy.service
             ├─23229 /usr/bin/python3 /usr/bin/swift-proxy-server /etc/swift/proxy-server.conf
             ├─23375 /usr/bin/python3 /usr/bin/swift-proxy-server /etc/swift/proxy-server.conf
             └─23423 /usr/bin/python3 /usr/bin/swift-proxy-server /etc/swift/proxy-server.conf

Feb 14 21:19:07 juju-2b302b-zaza-8d2bffc075ea-4 swift[23423]: STDERR: The option "auth_url" is not known to keystonemiddleware
Feb 14 21:19:07 juju-2b302b-zaza-8d2bffc075ea-4 swift[23423]: STDERR: The option "username" is not known to keystonemiddleware
Feb 14 21:19:07 juju-2b302b-zaza-8d2bffc075ea-4 swift[23423]: STDERR: The option "password" is not known to keystonemiddleware
Feb 14 21:19:07 juju-2b302b-zaza-8d2bffc075ea-4 swift[23423]: STDERR: The option "project_domain_name" is not known to keystonemiddleware
Feb 14 21:19:07 juju-2b302b-zaza-8d2bffc075ea-4 swift[23423]: STDERR: The option "user_domain_name" is not known to keystonemiddleware
Feb 14 21:19:07 juju-2b302b-zaza-8d2bffc075ea-4 swift[23423]: STDERR: The option "project_name" is not known to keystonemiddleware
Feb 14 21:19:07 juju-2b302b-zaza-8d2bffc075ea-4 swift[23423]: STDERR: The option "signing_dir" is not known to keystonemiddleware
Feb 14 21:19:07 juju-2b302b-zaza-8d2bffc075ea-4 swift[23423]: STDERR: The option "__name__" is not known to keystonemiddleware
Feb 14 21:19:07 juju-2b302b-zaza-8d2bffc075ea-4 swift[23423]: AuthToken middleware is set with keystone_authtoken.service_token_roles_required set to False. This is backwards compatible but deprecated behaviour. Please set this to True.
Feb 14 21:19:07 juju-2b302b-zaza-8d2bffc075ea-4 swift[23229]: Started child 23423 from parent 23229

I only looked for release notes on one of these, signing_dir:

https://opendev.org/openstack/keystonemiddleware/src/branch/master/releasenotes/notes/bug-1649735-3c68f3243e474775.yaml

We probably need a new proxy-server.conf template for newer releases and determine if we need to replace these old options with different ones.

[JamesLin (jneo8)]

The full output is

Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "bind_port" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "workers" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "user" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "bind_ip" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "log_name" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "log_facility" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "log_level" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "log_address" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "log_headers" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "auth_url" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "username" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "password" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "project_domain_name" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "user_domain_name" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "project_name" is not known to keystonemiddleware
Apr 20 06:02:19 juju-f418a1-dev-9 swift[31943]: STDERR: The option "__name__" is not known to keystonemiddleware

And the line in https://opendev.org/openstack/charm-swift-proxy/src/commit/5f38205d3f84bd6b009dc500ff0a89d136beada0/charmhelpers/contrib/openstack/context.py#L478

which keep all variable in ctxt, cause this STDERR.

Maybe we need to fix the code how we construct the IdentityServiceContext?

[JamesLin (jneo8)]

Update:

The charm is not actually using charm-helpers to generate the `SwiftIdentityContext`

https://opendev.org/openstack/charm-swift-proxy/src/commit/5f38205d3f84bd6b009dc500ff0a89d136beada0/lib/swift_context.py#L163

So the context like `bind_port` will be used to generate the conf files: https://opendev.org/openstack/charm-swift-proxy/src/commit/5f38205d3f84bd6b009dc500ff0a89d136beada0/lib/swift_utils.py#L169

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-swift-proxy/+/838824

[JamesLin (jneo8)]

Also see: https://bugs.launchpad.net/swift/+bug/1920109

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-swift-proxy/+/838824
Committed: https://opendev.org/openstack/charm-swift-proxy/commit/daef40a83702593cce4d97c7fe2f7c4656c342e1
Submitter: "Zuul (22348)"
Branch: master

commit daef40a83702593cce4d97c7fe2f7c4656c342e1
Author: jneo8 <email address hidden>
Date: Thu Apr 21 14:31:33 2022 +0800

    Add new version template: yoga

    Closes-Bug: #1960866
    Change-Id: I90769c16ca05c725c212255da5cb04a5e36bdcda