cluster peer relation does not use extra-bindings

[James Page]

The cluster peer relation current sets {binding}-address for configuraton based networking options, however its not using any network space extra-bindings that may be used by the end user:

    settings = {}

    for addr_type in ADDRESS_TYPES:
        address = get_address_in_network(
            config('os-{}-network'.format(addr_type))
        )
        if address:
            settings['{}-address'.format(addr_type)] = address

    if config('prefer-ipv6'):
        private_addr = get_ipv6_addr(exc_list=[config('vip')])[0]
        settings['private-address'] = private_addr

    relation_set(relation_settings=settings)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/462739

[David Ames (thedac)]

This should solve things: https://review.openstack.org/462739
If that looks good we can repeat it in all the API charms.

Having said that, I have been digging through code and I cannot seem to find where
'{}-address'.format(addr_type) is consumed. So we set it in the join but I cannot find where it is referenced for any purpose including in the SSL bits.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/462739
Committed: https://git.openstack.org/cgit/openstack/charm-keystone/commit/?id=d62a2e75c3efb52d5e6a6d176c0c12a2cb263358
Submitter: Jenkins
Branch: master

commit d62a2e75c3efb52d5e6a6d176c0c12a2cb263358
Author: David Ames <email address hidden>
Date: Thu May 4 14:13:18 2017 -0700

    Network space aware address for cluster relation

    Use the get_relation_ip function for selecting addresses for the
    cluster relationship. Including overrides for the admin, internal,
    and public config settings or extra bindings.

    Change-Id: I6d92523be1707549751d7153cd395f7bae217952
    Partial-Bug: #1687439