Add validation to protocol
Bug #1864200 reported by
Giuseppe Petralia
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Rsyslog Charm |
Fix Released
|
Medium
|
Giuseppe Petralia | ||
| Rsyslog Forwarder HA Charm |
Won't Fix
|
Medium
|
Unassigned | ||
Bug Description
Config parameter protocol can have only three values: udp, tcp and relp.
At the moment a arbitrary string can be set with no errors showed on the juju status.
A validation of this parameter would be necessary to avoid silently falling in unexpected configurations.
Related branches
~peppepetra/charm-rsyslog:bug/1864200
Merged
into
~rsyslog-charmers/charm-rsyslog:master
at
revision 321abbfc1ad9e23396a4a7f4124d255fd28ecc8e
- Paul Goins: Approve
- Drew Freiberger (community): Approve
- Xav Paice: Pending requested
- Alvaro Uria: Pending requested
- Jeremy Lounder: Pending requested
-
Diff: 2103 lines (+1290/-148) (has conflicts)22 files modified.gitignore (+1/-0)
hooks/charmhelpers/__init__.py (+4/-4)
hooks/charmhelpers/contrib/charmsupport/nrpe.py (+63/-13)
hooks/charmhelpers/core/hookenv.py (+210/-15)
hooks/charmhelpers/core/host.py (+39/-7)
hooks/charmhelpers/core/host_factory/ubuntu.py (+29/-1)
hooks/charmhelpers/core/kernel.py (+2/-2)
hooks/charmhelpers/core/sysctl.py (+21/-4)
hooks/charmhelpers/fetch/__init__.py (+2/-0)
hooks/charmhelpers/fetch/archiveurl.py (+1/-1)
hooks/charmhelpers/fetch/python/__init__.py (+13/-0)
hooks/charmhelpers/fetch/python/debug.py (+54/-0)
hooks/charmhelpers/fetch/python/packages.py (+154/-0)
hooks/charmhelpers/fetch/python/rpdb.py (+56/-0)
hooks/charmhelpers/fetch/python/version.py (+32/-0)
hooks/charmhelpers/fetch/snap.py (+1/-1)
hooks/charmhelpers/fetch/ubuntu.py (+274/-84)
hooks/charmhelpers/fetch/ubuntu_apt_pkg.py (+267/-0)
hooks/charmhelpers/osplatform.py (+24/-3)
hooks/hooks.py (+26/-10)
metadata.yaml (+1/-1)
unit_tests/test_hooks.py (+16/-2)
~dparv/charm-rsyslog:bug/1864200
- Jeremy Lounder: Pending requested
- Xav Paice: Pending requested
- Drew Freiberger: Pending requested
- Alvaro Uria: Pending requested
-
Diff: 2094 lines (+1289/-148) (has conflicts)21 files modifiedhooks/charmhelpers/__init__.py (+4/-4)
hooks/charmhelpers/contrib/charmsupport/nrpe.py (+63/-13)
hooks/charmhelpers/core/hookenv.py (+210/-15)
hooks/charmhelpers/core/host.py (+39/-7)
hooks/charmhelpers/core/host_factory/ubuntu.py (+29/-1)
hooks/charmhelpers/core/kernel.py (+2/-2)
hooks/charmhelpers/core/sysctl.py (+21/-4)
hooks/charmhelpers/fetch/__init__.py (+2/-0)
hooks/charmhelpers/fetch/archiveurl.py (+1/-1)
hooks/charmhelpers/fetch/python/__init__.py (+13/-0)
hooks/charmhelpers/fetch/python/debug.py (+54/-0)
hooks/charmhelpers/fetch/python/packages.py (+154/-0)
hooks/charmhelpers/fetch/python/rpdb.py (+56/-0)
hooks/charmhelpers/fetch/python/version.py (+32/-0)
hooks/charmhelpers/fetch/snap.py (+1/-1)
hooks/charmhelpers/fetch/ubuntu.py (+274/-84)
hooks/charmhelpers/fetch/ubuntu_apt_pkg.py (+267/-0)
hooks/charmhelpers/osplatform.py (+24/-3)
hooks/hooks.py (+26/-10)
metadata.yaml (+1/-1)
unit_tests/test_hooks.py (+16/-2)
~dparv/charm-rsyslog:bug/1864200
- Drew Freiberger (community): Needs Fixing
- Alvaro Uria: Pending requested
- Jeremy Lounder: Pending requested
- Xav Paice: Pending requested
-
Diff: 2163 lines (+1298/-156) (has conflicts)24 files modifiedMakefile (+1/-1)
hooks/charmhelpers/__init__.py (+4/-4)
hooks/charmhelpers/contrib/charmsupport/nrpe.py (+63/-13)
hooks/charmhelpers/core/hookenv.py (+210/-15)
hooks/charmhelpers/core/host.py (+39/-7)
hooks/charmhelpers/core/host_factory/ubuntu.py (+29/-1)
hooks/charmhelpers/core/kernel.py (+2/-2)
hooks/charmhelpers/core/sysctl.py (+21/-4)
hooks/charmhelpers/fetch/__init__.py (+2/-0)
hooks/charmhelpers/fetch/archiveurl.py (+1/-1)
hooks/charmhelpers/fetch/python/__init__.py (+13/-0)
hooks/charmhelpers/fetch/python/debug.py (+54/-0)
hooks/charmhelpers/fetch/python/packages.py (+154/-0)
hooks/charmhelpers/fetch/python/rpdb.py (+56/-0)
hooks/charmhelpers/fetch/python/version.py (+32/-0)
hooks/charmhelpers/fetch/snap.py (+1/-1)
hooks/charmhelpers/fetch/ubuntu.py (+274/-84)
hooks/charmhelpers/fetch/ubuntu_apt_pkg.py (+267/-0)
hooks/charmhelpers/osplatform.py (+24/-3)
hooks/hooks.py (+29/-13)
hooks/install (+2/-2)
metadata.yaml (+1/-0)
tox.ini (+1/-1)
unit_tests/test_hooks.py (+18/-4)
~woutervb/charm-rsyslog:bug/1864200
- Alvaro Uria (community): Needs Fixing
- Jeremy Lounder (community): Approve
- Wouter van Bommel (community): Needs Resubmitting
- Xav Paice (community): Approve
-
Diff: 205 lines (+52/-21)6 files modifiedMakefile (+1/-1)
hooks/hooks.py (+29/-13)
hooks/install (+2/-2)
metadata.yaml (+1/-0)
tox.ini (+1/-1)
unit_tests/test_hooks.py (+18/-4)
| Changed in charm-rsyslog-forwarder-ha: | |
| importance: | Undecided → Medium |
| Changed in charm-rsyslog: | |
| importance: | Undecided → Medium |
| Changed in charm-rsyslog-forwarder-ha: | |
| status: | New → Triaged |
| Changed in charm-rsyslog: | |
| status: | New → Triaged |
| Changed in charm-rsyslog: | |
| assignee: | nobody → Wouter van Bommel (woutervb) |
| Changed in charm-rsyslog: | |
| milestone: | none → 20.05 |
| Changed in charm-rsyslog: | |
| milestone: | 20.05 → 20.08 |
| Changed in charm-rsyslog: | |
| assignee: | Wouter van Bommel (woutervb) → Giuseppe Petralia (peppepetra) |
| status: | Triaged → Fix Released |
Revision history for this message
| Robert Gildein (rgildein) wrote | #1 |
| Changed in charm-rsyslog-forwarder-ha: | |
| status: | Triaged → Won't Fix |
To post a comment you must log in.
Is this bug really related w/ charm-rsyslog-