rabbitmq-server from ch latest/edge fails installation

[Billy Olsen]

The rabbitmq-server charm from latest/edge (revno 124) is failing installation with the following stack:

Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-rabbitmq-server-0/charm/hooks/install.real", line 39, in <module>
    import rabbit_utils as rabbit
  File "/var/lib/juju/agents/unit-rabbitmq-server-0/charm/hooks/rabbit_utils.py", line 41, in <module>
    from rabbitmq_context import (
  File "/var/lib/juju/agents/unit-rabbitmq-server-0/charm/hooks/rabbitmq_context.py", line 23, in <module>
    import ssl_utils
  File "/var/lib/juju/agents/unit-rabbitmq-server-0/charm/hooks/ssl_utils.py", line 18, in <module>
    from charmhelpers.contrib.ssl.service import ServiceCA
ModuleNotFoundError: No module named 'charmhelpers'

When reviewing the version deployed, the charmhelpers library is not included. Other hook-based classic charms have the charmhelpers library as part of the hooks/ directory but the rabbit charm has it at the top level.

$ juju download --track latest/edge rabbitmq-server
$ zip -sf rabbitmq-server_767dddc.charm | grep charmhelpers

results in nothing.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-rabbitmq-server/+/828990

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-rabbitmq-server/+/828990
Committed: https://opendev.org/openstack/charm-rabbitmq-server/commit/c01df1bc3564d337fa5bf2d59b76e49efe8aeefd
Submitter: "Zuul (22348)"
Branch: master

commit c01df1bc3564d337fa5bf2d59b76e49efe8aeefd
Author: Billy Olsen <email address hidden>
Date: Sun Feb 13 20:40:13 2022 -0700

    Add charmhelpers to charmcraft.yaml

    Charmhelpers directory was missed in the conversion to the charmcraft
    way of building charms. The rabbit charm has a slightly different
    location for charmhelpers than other charms. Add charmhelpers to
    charmcraft.yaml to ensure it is packed in the charm file.

    Change-Id: I72155c4bd2ace7497d59eeec3552985aec39d44b
    Closes-Bug: #1960769

[Alex Kavanagh (ajkavanagh)]

This does show the 'hole' in the CI where (for classic charms) it still doesn't use the built artifact in the CI tests. I guess we should prioritise that work.