check_rabbitmq_queues.py results in TypeError

[Xav Paice]

On upgrade to cs:rabbitmq-server-83 (from -82, and from 18.08), the nrpe check check_rabbitmq_queues.py returns a traceback:

/usr/local/lib/nagios/plugins/check_rabbitmq_queues.py -c \* \* 500 600 /var/lib/rabbitmq/data/juju-8ea30b-0-lxd-20_queue_stats.dat
Traceback (most recent call last):
  File "/usr/local/lib/nagios/plugins/check_rabbitmq_queues.py", line 91, in <module>
    stats_collated = collate_stats(stats, args.c)
  File "/usr/local/lib/nagios/plugins/check_rabbitmq_queues.py", line 38, in collate_stats
    for vhost, queue, m_all in stats:
  File "/usr/local/lib/nagios/plugins/check_rabbitmq_queues.py", line 22, in gen_stats
    for line in data_lines:
  File "/usr/local/lib/nagios/plugins/check_rabbitmq_queues.py", line 17, in gen_data_lines
    if not line.startswith("#"):
TypeError: startswith first arg must be bytes or a tuple of bytes, not str

[Alex Kavanagh (ajkavanagh)]

Well, that's embarrassing. I missed that on the last bug fix. Sadly we have no check for this; we probably need to think about how to improve it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/619227

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619227
Committed: https://git.openstack.org/cgit/openstack/charm-rabbitmq-server/commit/?id=065914d696ffb39c77696925b55b9795147cae00
Submitter: Zuul
Branch: master

commit 065914d696ffb39c77696925b55b9795147cae00
Author: Alex Kavanagh <email address hidden>
Date: Wed Nov 21 12:32:36 2018 +0000

    Fix more PY3 issues in check_rabbitmq_queues.py

    Note that, for PY3, the unbuffered IO in the check_rabbitmq.py script
    has to be switched off as PY3 doesn't support unbuffered IO for text
    (think str) rather than binary byte streams.

    Change-Id: I79af54cdbd7381f88732b24f65e94451350b9ab9
    Closes-Bug: #1804349
    Closes-Bug: #1804348

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.11
Review: https://review.openstack.org/619564

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619564
Committed: https://git.openstack.org/cgit/openstack/charm-rabbitmq-server/commit/?id=0a8455b0dfd07c017ed2d196c2ac73d68262c5df
Submitter: Zuul
Branch: stable/18.11

commit 0a8455b0dfd07c017ed2d196c2ac73d68262c5df
Author: Alex Kavanagh <email address hidden>
Date: Wed Nov 21 12:32:36 2018 +0000

    Fix more PY3 issues in check_rabbitmq_queues.py

    Note that, for PY3, the unbuffered IO in the check_rabbitmq.py script
    has to be switched off as PY3 doesn't support unbuffered IO for text
    (think str) rather than binary byte streams.

    Closes-Bug: #1804349
    Closes-Bug: #1804348
    (cherry picked from commit 065914d696ffb39c77696925b55b9795147cae00)

    Change-Id: I928c2e30d0025d0d1901dd85051e8e72dcd21a07