Supplying a base64 encoded cert via ssl_ca breaks

Bug #1798066 reported by Liam Young
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack RabbitMQ Server Charm
Fix Released
High
Liam Young

Bug Description

The config.yaml says that ssl_ca should be base64 encoded but when the charm sets the sll_ca down its relation it base64 encoded the supplied option which means the clients get a double encoding

Liam Young (gnuoy)
Changed in charm-rabbitmq-server:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Liam Young (gnuoy)
milestone: none → 18.11
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-rabbitmq-server (master)

Fix proposed to branch: master
Review: https://review.openstack.org/611125

Changed in charm-rabbitmq-server:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-rabbitmq-server (master)

Reviewed: https://review.openstack.org/611125
Committed: https://git.openstack.org/cgit/openstack/charm-rabbitmq-server/commit/?id=9ccf6d2b9535751ae3f586a771635347a9717049
Submitter: Zuul
Branch: master

commit 9ccf6d2b9535751ae3f586a771635347a9717049
Author: Liam Young <email address hidden>
Date: Tue Oct 16 18:33:48 2018 +0000

    Only b64encode ssl_ca if it needs it

    The description of the ssl_ca config option in config.yaml states
    that the certificate should be base64 encoded. But if it is then
    the charm b64encodes it again when sending the ca down the client
    relations. This change gates encoding the ca on whether it is
    already encoded.

    Change-Id: I9828d7567fd7f04cd0d80229ea1ff1275ea4269e
    Closes-Bug: #1798066

Changed in charm-rabbitmq-server:
status: In Progress → Fix Committed
David Ames (thedac)
Changed in charm-rabbitmq-server:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.