tcp_listeners option is hardcoded to have port 5672

Bug #1733099 reported by Dmitrii Shcherbakov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack RabbitMQ Server Charm
Triaged
Wishlist
Unassigned

Bug Description

Albeit this won't be used much in practice, there is currently no ability to change a default rabbitmq port (non-TLS).

https://git.io/vFHvc

templates/rabbitmq.config

{%- if ssl_only %}
        {tcp_listeners, []},
{% else %}
     {tcp_listeners, [5672]},

The reason not to hard-code it in the charm is fairly simple: we have to hardcode it in charm-helpers, charm-layer-openstack and any other place where we might need it while it could be passed via a relation without hiding that.

https://github.com/juju/charm-helpers/search?utf8=%E2%9C%93&q=5672&type=

The final goal is to remove hard-coded values in charm-helpers and define an auto-accessor in charm-interface-rabbitmq to properly render transport_url https://bugs.launchpad.net/layer-openstack/+bug/1733072

https://github.com/openstack/charm-interface-rabbitmq/blob/master/requires.py#L27-L28
class RabbitMQRequires(RelationBase):
    scope = scopes.GLOBAL

    # These remote data fields will be automatically mapped to accessors
    # with a basic documentation string provided.
    auto_accessors = ['password', 'private-address', 'ssl_port',
                      'ssl_ca', 'ha_queues', 'ha-vip-only', 'clustered', 'vip'] # <-- tcp_port goes here

Revision history for this message
James Page (james-page) wrote :

Do you have a specific requirement to be able to change this port? I'm actually in favour of dropping all port based configuration options; we only test with the default upstream port configs, and I suspect alot of things will break if you try to change anything ATM.

Changed in charm-rabbitmq-server:
status: New → Incomplete
importance: Undecided → Low
Revision history for this message
Dmitrii Shcherbakov (dmitriis) wrote :

Nothing specific.

It seemed like a valid option to be consistent with having the ability to configure the TLS port.

Changed in charm-rabbitmq-server:
status: Incomplete → New
James Page (james-page)
Changed in charm-rabbitmq-server:
status: New → Triaged
importance: Low → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.