Service restarted on every update-status due to identity-credentials.connected reactive event.

[Jorge Niedbalski]

[Environment]

Juju 2.6.3

[Description]

Service gets restarted on every update-status hook whether or not
the keystone credentials have changed.

1) The update-status hook triggers the identity-credentials.connected event (https://git.launchpad.net/prometheus-openstack-exporter-charm/tree/reactive/openstack_exporter.py#n87) ,

2) the identity-credentials.available event gets executed
https://git.launchpad.net/prometheus-openstack-exporter-charm/tree/reactive/openstack_exporter.py#n93

3) The state set_state('exporter.do-reconfig') is placed

 https://git.launchpad.net/prometheus-openstack-exporter-charm/tree/reactive/openstack_exporter.py#n96

4) The snap openstack-exporter service gets restarted.

217390-2019-06-28 14:44:29 INFO juju-log Reactive main running for hook update-status
217391-2019-06-28 14:44:29 INFO juju-log Initializing Snap Layer
217392-2019-06-28 14:44:29 DEBUG update-status lxc
217393-2019-06-28 14:44:30 INFO juju-log Invoking reactive handler: reactive/openstack_exporter.py:87:configure_keystone_username
217394-2019-06-28 14:44:30 INFO juju-log Invoking reactive handler: reactive/openstack_exporter.py:93:save_creds
217395-2019-06-28 14:44:32 INFO juju-log Invoking reactive handler: reactive/openstack_exporter.py:99:check_reconfig_exporter
217396-2019-06-28 14:44:32 INFO juju-log Invoking reactive handler: reactive/openstack_exporter.py:223:configure_exporter_service
217397-2019-06-28 14:44:32 INFO juju-log Invoking reactive handler: reactive/openstack_exporter.py:229:update_nrpe_config
217398-2019-06-28 14:44:33 INFO juju-log Setting charm primary status True
217399-2019-06-28 14:44:33 INFO juju-log Invoking reactive handler: reactive/openstack_exporter.py:168:render_config
217400-2019-06-28 14:44:33 INFO juju-log render_config: Got credentials for username=prometheus-openstack-exporter
217401-2019-06-28 14:44:33 INFO juju-log render_config: Using provided ssl_ca
217402-2019-06-28 14:44:33 INFO juju-log Invoking reactive handler: reactive/openstack_exporter.py:216:do_restart
217403-2019-06-28 14:44:33 DEBUG update-status active
217404:2019-06-28 14:44:33 INFO juju-log Restarting snap.prometheus-openstack-exporter.prometheus-openstack-exporter.service, config file changed...

[Tom Haddon (mthaddon)]

This has been tested in CI for a charm upgrade from the current released version, and a deploy from scratch. It's now been released as cs:prometheus-openstack-exporter-8. I'll leave the bug status untouched until someone can confirm the issue is fixed with this deployed version.