backup action fails as cannot retrieve sst-password

[Xav Paice]

When running the backup action, the import of _get_password from percona_utils does not complete, and therefore we end up with the innobackupex command having --password=None.

If we change the name of the method in percona_utils to get_password (i.e., not private), things work OK.

[Xav Paice (xavpaice)]

https://review.openstack.org/#/c/591851/

[James Page (james-page)]

Hi Xav

_ is a python convention rather than something that is enforced - so I'm not sure that dropping the prefix should change behaviour in any way?

[Xav Paice (xavpaice)]

Agreed - however, the effect by design or otherwise is that the import of _get_password from a separate module imports the name with no code. If, within pdb, I re-run the import within the backup method everything is fine. If I rename _get_password to get_password, everything works fine.

I'm not claiming to understand why that's the case, just that renaming seems to make life a little easier.

[Xav Paice (xavpaice)]

This is fixed in https://review.openstack.org/#/c/577346/, I'll abandon my change and mark this as fix fix committed.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Xav Paice (<email address hidden>) on branch: master
Review: https://review.openstack.org/591851
Reason: Alternate fix, https://review.openstack.org/#/c/577346/