Re-struct DeferredEventMixin class

Bug #1937855 reported by Gabriel Cocenza
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
charm-ovn-chassis
Triaged
Wishlist
Unassigned

Bug Description

The way that the custom_assess_status_check is declared in DeferredEventMixin prevents it from being defined elsewhere and this may cause conflicts in future implementations and features.

Having DeferredEventMixin separated from the BaseOVNChassisCharm has the benefit of allowing the deferred event functionality to be added or removed for each Openstack release, but it might not be optimal having methods of the class OpenStackCharm outside BaseOVNChassisCharm that are inherit just in the OpenStack release (TrainOVNChassisCharm and UssuriOVNChassisCharm).

I see two possible ways of solving this:

- Inherit DeferredEventMixin inside BaseOVNChassisCharm and declare the method custom_assess_status_check inside BaseOVNChassisCharm;

- Rename the method and have a new custom_assess_status_check for each release that would call this renamed method and others that might be needed.

Thanks!

Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

Although this is true, it's hard to see what to do about it "now". About the only thing I would suggest is putting a not against the function and linking to this bug.

Changed in charm-ovn-chassis:
importance: Undecided → Wishlist
status: New → Triaged
tags: added: good-first-bug
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.