Intermittent failure for unit_tests.test_lib_charms_ovn_central.TestOVNCentralCharm.test_configure_deferred_restarts

[Frode Nordahl]

{3} unit_tests.test_lib_charms_ovn_central.TestOVNCentralCharm.test_configure_deferred_restarts [0.009567s] ... FAILED

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/home/zuul/src/opendev.org/x/charm-ovn-central/unit_tests/test_lib_charms_ovn_central.py", line 611, in test_configure_deferred_restarts
    self.configure_deferred_restarts.assert_called_once_with(

      File "/usr/lib/python3.10/unittest/mock.py", line 931, in assert_called_once_with
    return self.assert_called_with(*args, **kwargs)

      File "/usr/lib/python3.10/unittest/mock.py", line 919, in assert_called_with
    raise AssertionError(_error_message()) from cause

    AssertionError: expected call not found.
Expected: configure_deferred_restarts(['ovn-central', 'ovn-ovsdb-server-nb', 'ovn-northd', 'ovn-ovsdb-server-sb'])
Actual: configure_deferred_restarts(['ovn-ovsdb-server-sb', 'ovn-northd', 'ovn-central', 'ovn-ovsdb-server-nb'])

Possibly a missing sort() or `any_order=True` argument

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/x/charm-ovn-central/+/869287

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Frode Nordahl <email address hidden>" on branch: master
Review: https://review.opendev.org/c/x/charm-ovn-central/+/869287
Reason: Folded into https://review.opendev.org/c/x/charm-ovn-central/+/869165

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/x/charm-ovn-central/+/869165
Committed: https://opendev.org/x/charm-ovn-central/commit/bbb1584893161f3a252817b178e7529048b1d51c
Submitter: "Zuul (22348)"
Branch: master

commit bbb1584893161f3a252817b178e7529048b1d51c
Author: Frode Nordahl <email address hidden>
Date: Tue Jan 3 11:32:21 2023 +0100

    tox.ini: Fixup

    Remove pins.

    Properly format passenv list.

    Drop the outer tox.ini func-target hack.

    Drop the incepted tox in src/test-requirements.txt.

    Drop pip.sh script.

    Fix undeterministic check in test_configure_deferred_restarts

    The test checks output of a class property that provides a list
    in undetermined order.

    Mocking class properties is non-trivial so let's just sort the
    result and expected list.

    Closes-Bug: #2001893
    Change-Id: I25dec5d1853a5aeb686df353d7c661f4a6eb5b69

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Martin Kalcok <email address hidden>" on branch: stable/22.03
Review: https://review.opendev.org/c/x/charm-ovn-central/+/889292