Only changes to os-credentials trigger configuration updates
Bug #1822646 reported by
Andrea Ieri
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| charm-openstack-service-checks |
Fix Released
|
Low
|
Alvaro Uria | ||
Bug Description
Changes to any option that is not os-credentials is silently ignored.
If os-credentials is updated, though, all checks are re-rendered and previously requested changes are applied.
I believe this to be stemming from only having the following in the code:
@when('
Since there is no generic @when('
Related branches
~anonybodi/charm-openstack-service-checks:reconfigure-on-configchanged
Merged
into
~canonical-bootstack/charm-openstack-service-checks:master
at
revision b241281c3a9cf5448a93633e345f9f360122b569
- Jeremy Lounder (community): Approve
- Drew Freiberger (community): Approve
-
Diff: 16 lines (+5/-0)1 file modifiedreactive/openstack_service_checks.py (+5/-0)
~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks:bug/1835433
Merged
into
~canonical-bootstack/charm-openstack-service-checks:master
at
revision 533a90c9d6b59ee4f00694cd398c43ac67ef774f
- Jeremy Lounder (community): Approve
- Alex Kavanagh: Pending requested
-
Diff: 979 lines (+696/-46)12 files modifiedREADME.md (+37/-1)
config.yaml (+18/-0)
files/plugins/check_rally.py (+100/-0)
files/run_rally.py (+88/-0)
layer.yaml (+8/-0)
lib/lib_openstack_service_checks.py (+242/-11)
reactive/openstack_service_checks.py (+17/-5)
templates/ostests.txt.j2 (+34/-0)
tests/functional/conftest.py (+12/-5)
tests/functional/test_deploy.py (+120/-22)
tests/unit/test_lib.py (+19/-2)
tox.ini (+1/-0)
~xavpaice/charm-openstack-service-checks/+git/charm-openstack-service-checks:reconfigure-on-configchanged
Merged
into
~canonical-bootstack/charm-openstack-service-checks:master
at
revision 869d5d5432e3baa5f9baa54ee716ecc1aff8e3ef
- Wouter van Bommel (community): Approve
-
Diff: 16 lines (+5/-0)1 file modifiedreactive/openstack_service_checks.py (+5/-0)
~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks:bug/1825860
Merged
into
~canonical-bootstack/charm-openstack-service-checks:master
at
revision 248082420e89f6f693bd8ab70e1605f73f495980
- David O Neill (community): Approve
-
Diff: 74 lines (+18/-8)2 files modifiedlib/lib_openstack_service_checks.py (+9/-4)
reactive/openstack_service_checks.py (+9/-4)
| Changed in charm-openstack-service-checks: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Changed in charm-openstack-service-checks: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Alvaro Uria (aluria) |
| Changed in charm-openstack-service-checks: | |
| status: | In Progress → Fix Released |
Revision history for this message
| Alvaro Uria (aluria) wrote | #1 |
To post a comment you must log in.
"config.changed" verification has been moved to the @when('
Fix has been released in the cs on rev=22.