Cannot customize SITE_BRANDING, SITE_BRANDING_LINK and help_url

Bug #1959366 reported by Nobuto Murata
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Charm Guide
Fix Released
Undecided
Nobuto Murata
OpenStack Dashboard Charm
Fix Released
Wishlist
Nobuto Murata

Bug Description

As per the following document, Horizon allows some customization such as HTML title(SITE_BRANDING), Logo link(SITE_BRANDING_LINK), and Help URL(HORIZON_CONFIG["help_url"]) through local_settings.py.

However, the charm doesn't allow to do so at the moment.

https://github.com/openstack/horizon/blob/master/doc/source/admin/customize-configure.rst#html-title

Changed in charm-openstack-dashboard:
importance: Undecided → Wishlist
status: New → Triaged
tags: added: good-first-bug
Revision history for this message
Nobuto Murata (nobuto) wrote :

There is a hack available to put local_setting.py under the custom theme directory and upload it as a Juju resource:
https://github.com/openstack/charm-openstack-dashboard#custom-theme

However, the settings there are per theme basis so an ability to put those values to the global local_settings.py is necessary to apply the values for all themes.

Nobuto Murata (nobuto)
Changed in charm-openstack-dashboard:
assignee: nobody → Nobuto Murata (nobuto)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-openstack-dashboard (master)
Changed in charm-openstack-dashboard:
status: Triaged → In Progress
Revision history for this message
Nobuto Murata (nobuto) wrote :

Subscribing ~field-medium.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-openstack-dashboard (master)

Reviewed: https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/827105
Committed: https://opendev.org/openstack/charm-openstack-dashboard/commit/bd0eed2c849d165755371dcfbb4bbb6dd9a5bfad
Submitter: "Zuul (22348)"
Branch: master

commit bd0eed2c849d165755371dcfbb4bbb6dd9a5bfad
Author: Nobuto Murata <email address hidden>
Date: Mon Jan 31 23:14:22 2022 +0900

    Allow customization of branding

    Make the following values configurable:
    - SITE_BRANDING
    - SITE_BRANDING_LINK
    - HORIZON_CONFIG["help_url"]

    Closes-Bug: #1959366
    Change-Id: I34716bd68cc50b53dd28f6bb7a19409ece355465

Changed in charm-openstack-dashboard:
status: In Progress → Fix Committed
Felipe Reyes (freyes)
Changed in charm-openstack-dashboard:
milestone: none → 22.04
Nobuto Murata (nobuto)
Changed in charm-guide:
assignee: nobody → Nobuto Murata (nobuto)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-guide (master)
Changed in charm-guide:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-guide (master)

Reviewed: https://review.opendev.org/c/openstack/charm-guide/+/837655
Committed: https://opendev.org/openstack/charm-guide/commit/664e89f68f6fc642f94b02999e41604daef5718a
Submitter: "Zuul (22348)"
Branch: master

commit 664e89f68f6fc642f94b02999e41604daef5718a
Author: Nobuto Murata <email address hidden>
Date: Wed Apr 13 12:00:02 2022 +0900

    release-notes: openstack-dashboard branding

    Closes-Bug: #1959366
    Change-Id: I55ad526e18cfd6d94347dc5e7a4eda60129c7391

Changed in charm-guide:
status: In Progress → Fix Released
Changed in charm-openstack-dashboard:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.