Attaching a new custom theme doesn't clean the previous one

[Giuseppe Petralia]

Charm rev. ch:openstack-dashboard-514

I have an initial-custom-theme.tgz containing: "static/","templates/","local_settings.py"

I attach it with:

juju attach-resource openstack-dashboard theme=initial-custom-theme.tgz
juju config openstack-dashboard custom-theme=true

and in the unit I see:

root@juju-10df85-default-24:/usr/share/openstack-dashboard/openstack_dashboard/themes/custom# ls
local_settings.py static templates

Then I want to get rid of templates folder in the custom theme.

I create a new-theme.tgz containing only: "static/", "local_settings.py"

I attach it with: juju attach-resource openstack-dashboard theme=new-theme.tgz
and although I can see local_settings.py and static being updated, templates folder is not removed.

Charm should clean any previous file/folder of the custom-theme before extracting the new one to avoid side-effect depending on files not needed by the new theme attached.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "James Page <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/816795
Reason: This review is > 12 weeks without comment, and failed testing the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.