Charm Support for disable_password_reveal

[Mihaela Andronic]

Hi,

Our Customer needs to disable the reveal button for password fields, including on the login form for security reasons.

At a first inspection of the juju config parameters for the openstack-dashboard application on the cloud environment, we cannot see this option available within the charm.

Our Engineers managed to to MANUALLY add the option that was requested within a Juju deployed OpenStack lab, where they made the following changes to a test unit for the openstack-dashboard application.

#STEPS#

First, created the following settings snippet:

sudo su -c "cat > /usr/share/openstack-dashboard/openstack_dashboard/local/local_settings.d/_20_disable_password_reveal.py <<'EOF'
HORIZON_CONFIG['disable_password_reveal'] = True
EOF"

After restarting the OpenStack dashboard, on the dashboard login page, they could confirm that the reveal GUI option was now gone, as intended.

IMPORTANT NOTE: if we are to manually add this configuration to the openstack-dashboard units within the cloud environment, it will not survive an application redeploy. Also, as of yet we have not been able to confirm yet whether the charm will not overwrite this directory altogether, wiping away the changes made.

We are opening this BUG as a request to make the setting available from charm option.

Thanks in advance,
Kind Regards

[Xav Paice (xavpaice)]

https://review.opendev.org/#/c/678723/

[Xav Paice (xavpaice)]

subscribed field-medium, because this is blocking a customer's security audit.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/678723
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=957a6adc0351276f36dc48718aa6d233072caff6
Submitter: Zuul
Branch: master

commit 957a6adc0351276f36dc48718aa6d233072caff6
Author: Xav Paice <email address hidden>
Date: Tue Aug 27 16:56:16 2019 +1200

    Add disable-password-reveal option

    Adds config item to add HORIZON_CONFIG['disable_password_reveal'] = True
    option to Horizon's local_settings.py, from Mitaka onwards. This
    prevents the reveal password button from being displayed.

    Change-Id: I299f6a6388c3a2ab68cabaeb16e5104ec319e144
    Closes-bug: #1840251

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/19.07
Review: https://review.opendev.org/731083

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/19.10
Review: https://review.opendev.org/731084

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/20.02
Review: https://review.opendev.org/731086

[OpenStack Infra (hudson-openstack)]

Change abandoned by "James Page <email address hidden>" on branch: stable/19.07
Review: https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/731083
Reason: Review targets obsolete stable branch

[OpenStack Infra (hudson-openstack)]

Change abandoned by "James Page <email address hidden>" on branch: stable/19.10
Review: https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/731084
Reason: Review targets obsolete stable branch

[OpenStack Infra (hudson-openstack)]

Change abandoned by "James Page <email address hidden>" on branch: stable/20.02
Review: https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/731086
Reason: This review is > 12 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.