Neutron FWaaS panel missing from dashboard on Queens

Bug #1808168 reported by Lorenzo Cavassa on 2018-12-12
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack openstack-dashboard charm
High
James Page
Ubuntu Cloud Archive
Status tracked in Stein
Queens
High
James Page
Rocky
Undecided
Unassigned
Stein
Undecided
Unassigned
Ubuntu
Undecided
Unassigned
Bionic
High
James Page
Cosmic
Undecided
Unassigned
Disco
Undecided
Unassigned
neutron-fwaas-dashboard (Ubuntu)
Undecided
Unassigned
Bionic
High
James Page
Cosmic
Undecided
Unassigned
Disco
Undecided
Unassigned

Bug Description

[Impact]
FwaaS functionality is not accessible from the OpenStack Dashboard

[Test Case]
Deploy Queens based OpenStack Cloud (using charms + juju).
OpenStack dashboard does not have Project->Network->Firewall navigation and associate functionality

[Regression Potential]
Low; this is a new leaf package that adds to the function of the openstack-dashboard package. Equivalent package is found in >= Cosmic.

[Original Bug Report]
Xenial + Queens.

The FWaaS GUI panel is missing even if the service it's enabled and the Neutron extension is there:

neutron ext-list|grep fwaas

| fwaasrouterinsertion | FWaaS Router Insertion |
| fwaas | FWaaS v1 |

subscribed ~field-critical

James Page (james-page) wrote :

neutron-fwaas-dashboard was introduce in cosmic at 1.5.0; we'll need to have 1.3.0 in bionic to support this feature for Queens Cloud Deployments.

This means introducing a NEW package to bionic

Changed in charm-openstack-dashboard:
importance: Undecided → High
status: New → Triaged
Changed in cloud-archive:
status: New → Fix Released
James Page (james-page) wrote :

part two will involve a timed stable charm update for the openstack-dashboard to install the package once its available.

summary: - FwwS GUI panel missing on Queens
+ Neutron FwaaS GUI panel missing from dashboard on Queens

Unsubscribing ~field-critical because this doesn't fall under the SLA.

James Page (james-page) on 2018-12-13
description: updated
James Page (james-page) wrote :

Testing packages for bionic and xenial here:

  https://launchpad.net/~james-page/+archive/ubuntu/queens/+packages

testing on a fresh queens deploy now.

James Page (james-page) wrote :

To install and enable:

  sudo add-apt-repository ppa:james-page/queens
  sudo apt install python-neutron-fwaas-dashboard
  sudo systemctl restart apache2

James Page (james-page) wrote :

neutron-fwaas-dashboard 1.3.0-0ubuntu1 upload to bionic unapproved queue for SRU team review.

This is the required version for OpenStack queens (as shipped in bionic) and is based on the packaging in cosmic for OpenStack rocky; the packaging has been switched to ship py2 based packages as this is the default and only option for the dashboard on bionic.

James Page (james-page) wrote :

The versions in the PPA are the same as what I have uploaded - they can be used in the interim and will be superceeded by the distro version once they have been tested and accepted into bionic.

James Page (james-page) on 2018-12-14
Changed in charm-openstack-dashboard:
assignee: nobody → James Page (james-page)
milestone: none → 19.04

Fix proposed to branch: master
Review: https://review.openstack.org/625212

Changed in charm-openstack-dashboard:
status: Triaged → In Progress
James Page (james-page) on 2018-12-14
summary: - Neutron FwaaS GUI panel missing from dashboard on Queens
+ Neutron FWaaS panel missing from dashboard on Queens
Łukasz Zemczak (sil2100) wrote :

I looked at the neutron-fwaas-dashboard package in the xenial NEW queue and I have some question. There are obviously some differences between 1.3.0 in cosmic and the one backported to bionic. This makes the review a bit less straightforward as our regular SRU NEW package-backport policies do not apply.

The most obvious changes are the ones from py3 -> py2 which has been explained in this bug, so I'll skip that part. There are some others that I'd first want to know some about .

1) I noticed that in the cosmic package the tests were ran during override_dh_install (which did seem a bit strange to me) but now have moved to the proper place in override_dh_auto_test. What was the reason that it was previously done at a different step?

2) In the original cosmic package, in override_dh_install I see that some static files were being copied over to /usr/share/openstack-dashboard/openstack_dashboard/static etc. which is not happening anymore in the bionic backport. Everything else moved to override_dh_auto_install. Are those now installed as part of pkgos-dh_auto_install ? Why did the installation stages move so much?

3) This is a minor question (out of curiosity), just wanted to get some context on this: why is 1.3.0 backported instead of 1.5.0? Not a problem of course.

Thanks!

Łukasz Zemczak (sil2100) wrote :

s/xenial/bionic/ of course.

James Page (james-page) wrote :

Thanks for the review @sil2100

1) TBH I don't know - that's how it arrived in the first sync from Debian, but as we tidied the packaging last cycle we put things back in 'normal' places as much as possible.

2) That was not actually needed - the call to 'python manage.py collectstatic' in the postinst script will shuffle things around into the correct locations.

3) OpenStack publish release versions (https://releases.openstack.org/queens/#neutron-fwaas-dashboard) - 1.3.0 is the most recent fwaas-dashboard version that's know compatible with the rest of OpenStack queens. 1.5.0 is a Rocky version, so although it might just work, it would put Ubuntu out of alignment with upstream testing activities which generally is not super awesome.

Hope that explain things.

Łukasz Zemczak (sil2100) wrote :

Ok, looks good I think, let me approve it. A note to other archive-admins/SRU members: there are some differences in packaging from the cosmic 1.3.0 upload, but most of them are either related to py3->py2 or are actually present in the cosmic+ 1.5.0 versions.

tags: added: verification-needed verification-needed-bionic

Hello Lorenzo, or anyone else affected,

Accepted neutron-fwaas-dashboard into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/neutron-fwaas-dashboard/1.3.0-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in neutron-fwaas-dashboard (Ubuntu Cosmic):
status: New → Invalid
Changed in neutron-fwaas-dashboard (Ubuntu Disco):
status: New → Invalid
Changed in neutron-fwaas-dashboard (Ubuntu Bionic):
status: New → Fix Committed
Steve Langasek (vorlon) on 2018-12-14
Changed in neutron-fwaas-dashboard (Ubuntu Bionic):
assignee: nobody → James Page (james-page)
importance: Undecided → High
tags: added: id-5c128dfc4c168a3f61c8ecc2
Łukasz Zemczak (sil2100) wrote :

Looking at the generated binary package, there's one tiny thing I don't like. Apparently it seems that the bionic version of the package ships some .pyc files (along with the right .py ones) in /usr/share/openstack-dashboard/openstack_dashboard/enabled/ . None of the other versions for other series (both 1.3.0 and 1.5.0) seem to ship any unneeded files like that. Do you know what change caused that? Can we get rid of those from the final binary?

Łukasz Zemczak (sil2100) wrote :

Hello Lorenzo, or anyone else affected,

Accepted neutron-fwaas-dashboard into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/neutron-fwaas-dashboard/1.3.0-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

James Page (james-page) wrote :

Using the proposed changes to the openstack-dashboard charm I was able to deploy horizon + the fwaas dashboard from bionic-proposed; panels appeared correctly in horizon and I was able to create/update/delete firewalls and rules for the v1 API as enabled in the charm deployment

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
James Page (james-page) wrote :

Hello Lorenzo, or anyone else affected,

Accepted neutron-fwaas-dashboard into queens-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:queens-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-queens-needed to verification-queens-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-queens-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-queens-needed
James Page (james-page) wrote :

Tested Xenial/Queens from Proposed with the proposed charm updates; firewall panel was present and functional within the OpenStack Dashboard.

tags: added: verification-queens-done
removed: verification-queens-needed

The verification of the Stable Release Update for neutron-fwaas-dashboard has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package neutron-fwaas-dashboard - 1.3.0-0ubuntu1.1

---------------
neutron-fwaas-dashboard (1.3.0-0ubuntu1.1) bionic; urgency=medium

  * d/rules: Only install py files when enabling panels for
    OpenStack dashboard.

neutron-fwaas-dashboard (1.3.0-0ubuntu1) bionic; urgency=medium

  * Initial release for Openstack Queens resolving disappearance
    of FWaaS panels from the OpenStack Dashboard (LP: #1808168).

 -- James Page <email address hidden> Mon, 17 Dec 2018 09:35:09 +0000

Changed in neutron-fwaas-dashboard (Ubuntu Bionic):
status: Fix Committed → Fix Released
James Page (james-page) wrote :

The verification of the Stable Release Update for neutron-fwaas-dashboard has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

James Page (james-page) wrote :

This bug was fixed in the package neutron-fwaas-dashboard - 1.3.0-0ubuntu1.1~cloud0
---------------

 neutron-fwaas-dashboard (1.3.0-0ubuntu1.1~cloud0) xenial-queens; urgency=medium
 .
   * New package for the Ubuntu Cloud Archive.
 .
 neutron-fwaas-dashboard (1.3.0-0ubuntu1.1) bionic; urgency=medium
 .
   * d/rules: Only install py files when enabling panels for
     OpenStack dashboard.
 .
 neutron-fwaas-dashboard (1.3.0-0ubuntu1) bionic; urgency=medium
 .
   * Initial release for Openstack Queens resolving disappearance
     of FWaaS panels from the OpenStack Dashboard (LP: #1808168).

Reviewed: https://review.openstack.org/625212
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=f365df6f0d35a9ac9c4e9b3ea314e88e356600f2
Submitter: Zuul
Branch: master

commit f365df6f0d35a9ac9c4e9b3ea314e88e356600f2
Author: James Page <email address hidden>
Date: Fri Dec 14 10:57:19 2018 +0000

    Enable fwaas dashboard for >= Queens

    OpenStack Queens or later requires the installation of the dashboard
    package for FWaaS to expose this feature in Horizon.

    Change-Id: Icc046ecbafe626d6af68bf65c0f62c424d370b2c
    Closes-Bug: 1808168

Changed in charm-openstack-dashboard:
status: In Progress → Fix Committed
David Ames (thedac) 20 hours ago
Changed in charm-openstack-dashboard:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers