Default-domain setting breaks Multidomain_support

[Tim Waters]

Today I found a bug in the 'default-domain' configuration of the openstack-dashboard charm.
I have deployed an OpenStack environment with two dashboard instances: One for admins and one for basic users that will always sign by using their domain account. As the users always sign into the same domain, I had wanted to remove the domain field on the logonpage and set the default domain.

The admin dashboard works fine, but while disabeling MultiDomainSupport in the users's OpenStack Dashboard instance ( juju config openstack-user-dashboard default-domain=<USERDOMAIN> ) the value ' KEYSTONE_MULTIDOMAIN_SUPPORT is incorrectly set.

The value FALSE is set as a string in local_settings.py instead of a boolean and as a result the value is discarded and the default 'true' is used.

Removing the quotes around "False" fixes the problem.

[Nobuto Murata (nobuto)]

Hi Tim, thank you for the detailed bug report. I will propose a fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/535865

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/535865
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=48119619a0df4445432bfcbcb0a5a0a585226774
Submitter: Zuul
Branch: master

commit 48119619a0df4445432bfcbcb0a5a0a585226774
Author: Nobuto Murata <email address hidden>
Date: Fri Jan 19 17:31:30 2018 +0000

    OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT expects boolean

    Previously the single domain mode has been implemented. This is a
    follow-up commit to set the value properly as boolean instead of string.

    Change-Id: I0e34d93d05693bf0ca5e8f68bc9af198fd29680a
    Closes-Bug: #1744346
    Related-Bug: #1712999

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/17.11
Review: https://review.openstack.org/539410

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/539410
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=e4b809bcf1b6998c8a6aea06fab66f8abd18872b
Submitter: Zuul
Branch: stable/17.11

commit e4b809bcf1b6998c8a6aea06fab66f8abd18872b
Author: Nobuto Murata <email address hidden>
Date: Fri Jan 19 17:31:30 2018 +0000

    OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT expects boolean

    Previously the single domain mode has been implemented. This is a
    follow-up commit to set the value properly as boolean instead of string.

    Change-Id: I0e34d93d05693bf0ca5e8f68bc9af198fd29680a
    Closes-Bug: #1744346
    Related-Bug: #1712999
    (cherry picked from commit 48119619a0df4445432bfcbcb0a5a0a585226774)