Regression in haproxy check since LP#1713165

[James Hebden]

The original bug reported in LP#1713165 [0] suggested that the following part of the haproxy check was a problem when there were backups of the config file present, as it recursively greps the haproxy config directory.

AUTH=$(grep -r "stats auth" /etc/haproxy | awk 'NR=1{print $4}')

The suggestion fix was -
AUTH=$(egrep "stats auth" /etc/haproxy/haproxy.cfg | awk 'NR=1{print $3}')

The implemented fix was -
AUTH=$(egrep "stats auth" /etc/haproxy/haproxy.cfg | awk 'NR=1{print $4}')
Note the awk token was not correct, and per comments on the original bug [1] and GitHub PR [2]

Despite this, this change has also made it into the OpenStack charms via a charmhelpers sync, which means we also have a regression in the Charms.

In addition to this, the fix also needs to be applied to 'check_haproxy_queue_depth.sh' in the same directory.

So far, I have found this has been merged into the following OpenStack charms, but I suspect that there are likely many more charms which would have synced the latest charmhelpers -
* ceilometer
* ceilometer-agent
* ceph-radosgw
* cinder
* cinder-backup
* cinder-ceph
* glance
* heat
* neutron-api
* neutron-gateway
* neutron-openvswitch
* nova-cloud-controller
* nova-compute
* openstack-dashboard
* rabbitmq-server
* swift-proxy
* swift-storage

The impact is that all of these charms install NRPE checks for haproxy, which report all backends as being down (which is a critical level alert) falsely due to not being able to grab status API credentials correctly.

[0] https://bugs.launchpad.net/charm-helpers/+bug/1713165
[1] https://bugs.launchpad.net/charm-helpers/+bug/1713165/comments/3
[2] https://github.com/juju/charm-helpers/pull/6#issuecomment-352010772

[James Hebden (ec0)]

I have added the charm projects as well, as they will all need to be addressed by syncing a fixed charmhelpers version.

[James Hebden (ec0)]

I have removed and excluded services which carry the buggy charmhelpers code but would not be impacted due to lack of haproxy use.

[James Hebden (ec0)]

https://github.com/juju/charm-helpers/pull/90

[James Hebden (ec0)]

https://github.com/juju/charm-helpers/issues/91

[Corey Bryant (corey.bryant)]

Thanks for reporting/fixing this James and apologies for the regression.

[James Page (james-page)]

Raised https://github.com/juju/charm-helpers/pull/95 to cover this

[James Page (james-page)]

Fixed as part of charm-helpers resync in stable/17.11 branch