amphora images should be configured with hw_vif_multiqueue_enabled=true

[James Troup]

amphora images should be configured with hw_vif_multiqueue_enabled=true. This will make the VM kernel NIC driver set the number of queues equal to the number of guest vCPUs. This makes the network performance scale across a number of vCPUs.

https://docs.openstack.org/glance/stein/admin/useful-image-properties.html

[Dmitrii Shcherbakov (dmitriis)]

I think charm-octavia-diskimage-retrofit would be the right place for setting image properties for retrofitted images.

https://github.com/openstack/charm-octavia-diskimage-retrofit/blob/77559282fc46a4adb091614acc0748968e5b5775/src/lib/charm/openstack/octavia_diskimage_retrofit.py#L189-L219

[Joe Guo (guoqiao)]

1-line patch created: https://review.opendev.org/#/c/729892/

NOTE: I didn't add a config option for it, which seems overkill.
We can always disable it with:

openstack image set --property hw_vif_multiqueue_enabled=false $IMG_ID

[Vern Hart (vern)]

I applied the one-line change from that patch:

   hw_vif_multiqueue_enabled=True,

and tried running the retrofit-image action on the charm and after about 30 minutes I received this error message: https://pastebin.ubuntu.com/p/x83xvw4BWx/

Since it seems to be looking for a string, I changed my code to say

    hw_vif_multiqueue_enabled='true',

and tried again.

This time it completed without error.