cannot live-migrate to newly deployed nodes

[Rodrigo Barbieri]

Change [1] migrated the ceph credentials to
'nova-compute'. Existing nodes would retain
the old credentials (in addition to the new one)
upon upgrading the charm, while newly deployed
nodes would only have the new credentials.

It is expected that running VMs reboot to refresh their libvirt XML to obtain the new credentials. However, in production not every VM can be promptly rebooted, and sometimes they have to be migrated to newly deployed nodes for balancing, evacuation, scale-out, or other reasons that require a VM that cannot be powered off at that moment to be live-migrated.

The lack of old credentials in newly deployed nodes prevent existing VMs that haven't rebooted from being migrated to them, so the VMs may be stuck unable to migrate anywhere if they cannot be balanced through migrating. This is not an acceptable compromise.

[1] https://review.opendev.org/889642

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/896155

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Rodrigo Barbieri <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/896155
Reason: abandoning in favor of https://review.opendev.org/c/openstack/charm-nova-compute/+/897549

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/897549
Committed: https://opendev.org/openstack/charm-nova-compute/commit/650f3a5d511690ec27648b30f3b24532378a33a1
Submitter: "Zuul (22348)"
Branch: master

commit 650f3a5d511690ec27648b30f3b24532378a33a1
Author: Rodrigo Barbieri <email address hidden>
Date: Fri Oct 6 10:24:48 2023 -0300

    [v2] Fix migration across nova-compute apps using ceph

    This change reworks previous changes [1] and [2] that had
    been respectively reverted and abandoned.

    When using the config libvirt-image-backend=rbd, VMs
    created from image have their disk data stored in ceph
    instead of the compute node itself.

    When performing live-migrations, both nodes need to
    access the same ceph credentials to access the VM's
    disk in ceph, but this is currently not possible
    if the nodes involved pertain to different
    nova-compute charm apps.

    This patch changes app name sent to ceph to
    'nova-compute-ceph-auth-c91ce26f', a unique name common to
    all nova-compute apps, allowing all nova-compute apps to
    use the same ceph auth.

    This change also ensures newly deployed nodes install
    the old credentials first on ceph-joined hook,
    and then supercedes it with the new credentials
    on ceph-changed hook, therefore also retaining
    the old credentials.

    This patch also includes the charmhelpers sync
    from PR: #840

    [1] https://review.opendev.org/889642
    [2] https://review.opendev.org/896155

    Closes-bug: #2028559
    Related-bug: #2037003

    Func-Test-Pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/1149

    Change-Id: I1ae12d787a1f8e7761ca06b5a80049c1c62e9e90

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/905312

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/905312
Committed: https://opendev.org/openstack/charm-nova-compute/commit/28233f9a943f9c6c67d4934cf693869c9c03b1e4
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 28233f9a943f9c6c67d4934cf693869c9c03b1e4
Author: Rodrigo Barbieri <email address hidden>
Date: Fri Oct 6 10:24:48 2023 -0300

    [v2] Fix migration across nova-compute apps using ceph

    This change reworks previous changes [1] and [2] that had
    been respectively reverted and abandoned.

    When using the config libvirt-image-backend=rbd, VMs
    created from image have their disk data stored in ceph
    instead of the compute node itself.

    When performing live-migrations, both nodes need to
    access the same ceph credentials to access the VM's
    disk in ceph, but this is currently not possible
    if the nodes involved pertain to different
    nova-compute charm apps.

    This patch changes app name sent to ceph to
    'nova-compute-ceph-auth-c91ce26f', a unique name common to
    all nova-compute apps, allowing all nova-compute apps to
    use the same ceph auth.

    This change also ensures newly deployed nodes install
    the old credentials first on ceph-joined hook,
    and then supercedes it with the new credentials
    on ceph-changed hook, therefore also retaining
    the old credentials.

    [1] https://review.opendev.org/889642
    [2] https://review.opendev.org/896155

    Closes-bug: #2028559
    Related-bug: #2037003

    Func-Test-Pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/1183

    Change-Id: I1ae12d787a1f8e7761ca06b5a80049c1c62e9e90
    (cherry picked from commit 650f3a5d511690ec27648b30f3b24532378a33a1)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/906298

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/906298
Committed: https://opendev.org/openstack/charm-nova-compute/commit/ecaf8010fc6ee2e28e6a0f05cb2ae0a8ce25b5e6
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit ecaf8010fc6ee2e28e6a0f05cb2ae0a8ce25b5e6
Author: Rodrigo Barbieri <email address hidden>
Date: Fri Oct 6 10:24:48 2023 -0300

    [v2] Fix migration across nova-compute apps using ceph

    This change reworks previous changes [1] and [2] that had
    been respectively reverted and abandoned.

    When using the config libvirt-image-backend=rbd, VMs
    created from image have their disk data stored in ceph
    instead of the compute node itself.

    When performing live-migrations, both nodes need to
    access the same ceph credentials to access the VM's
    disk in ceph, but this is currently not possible
    if the nodes involved pertain to different
    nova-compute charm apps.

    This patch changes app name sent to ceph to
    'nova-compute-ceph-auth-c91ce26f', a unique name common to
    all nova-compute apps, allowing all nova-compute apps to
    use the same ceph auth.

    This change also ensures newly deployed nodes install
    the old credentials first on ceph-joined hook,
    and then supercedes it with the new credentials
    on ceph-changed hook, therefore also retaining
    the old credentials.

    [1] https://review.opendev.org/889642
    [2] https://review.opendev.org/896155

    Closes-bug: #2028559
    Related-bug: #2037003

    Func-Test-Pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/1183

    Change-Id: I1ae12d787a1f8e7761ca06b5a80049c1c62e9e90
    (cherry picked from commit 650f3a5d511690ec27648b30f3b24532378a33a1)
    (cherry picked from commit 28233f9a943f9c6c67d4934cf693869c9c03b1e4)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/908187

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/908187
Committed: https://opendev.org/openstack/charm-nova-compute/commit/8c3549d828c5ba0d6306b76494fdbd1abd9d8471
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 8c3549d828c5ba0d6306b76494fdbd1abd9d8471
Author: Rodrigo Barbieri <email address hidden>
Date: Fri Oct 6 10:24:48 2023 -0300

    [v2] Fix migration across nova-compute apps using ceph

    This change reworks previous changes [1] and [2] that had
    been respectively reverted and abandoned.

    When using the config libvirt-image-backend=rbd, VMs
    created from image have their disk data stored in ceph
    instead of the compute node itself.

    When performing live-migrations, both nodes need to
    access the same ceph credentials to access the VM's
    disk in ceph, but this is currently not possible
    if the nodes involved pertain to different
    nova-compute charm apps.

    This patch changes app name sent to ceph to
    'nova-compute-ceph-auth-c91ce26f', a unique name common to
    all nova-compute apps, allowing all nova-compute apps to
    use the same ceph auth.

    This change also ensures newly deployed nodes install
    the old credentials first on ceph-joined hook,
    and then supercedes it with the new credentials
    on ceph-changed hook, therefore also retaining
    the old credentials.

    [1] https://review.opendev.org/889642
    [2] https://review.opendev.org/896155

    Closes-bug: #2028559
    Related-bug: #2037003

    Func-Test-Pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/1183

    Change-Id: I1ae12d787a1f8e7761ca06b5a80049c1c62e9e90
    (cherry picked from commit 650f3a5d511690ec27648b30f3b24532378a33a1)
    (cherry picked from commit 28233f9a943f9c6c67d4934cf693869c9c03b1e4)
    (cherry picked from commit ecaf8010fc6ee2e28e6a0f05cb2ae0a8ce25b5e6)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/911153

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/911153
Committed: https://opendev.org/openstack/charm-nova-compute/commit/810d4b0fbac967d47ff793cc02f87da37cb5b578
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 810d4b0fbac967d47ff793cc02f87da37cb5b578
Author: Rodrigo Barbieri <email address hidden>
Date: Fri Oct 6 10:24:48 2023 -0300

    [v2] Fix migration across nova-compute apps using ceph

    This change reworks previous changes [1] and [2] that had
    been respectively reverted and abandoned.

    When using the config libvirt-image-backend=rbd, VMs
    created from image have their disk data stored in ceph
    instead of the compute node itself.

    When performing live-migrations, both nodes need to
    access the same ceph credentials to access the VM's
    disk in ceph, but this is currently not possible
    if the nodes involved pertain to different
    nova-compute charm apps.

    This patch changes app name sent to ceph to
    'nova-compute-ceph-auth-c91ce26f', a unique name common to
    all nova-compute apps, allowing all nova-compute apps to
    use the same ceph auth.

    This change also ensures newly deployed nodes install
    the old credentials first on ceph-joined hook,
    and then supercedes it with the new credentials
    on ceph-changed hook, therefore also retaining
    the old credentials.

    [1] https://review.opendev.org/889642
    [2] https://review.opendev.org/896155

    Closes-bug: #2028559
    Related-bug: #2037003

    Func-Test-Pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/1190

    Change-Id: I1ae12d787a1f8e7761ca06b5a80049c1c62e9e90
    (cherry picked from commit 650f3a5d511690ec27648b30f3b24532378a33a1)
    (cherry picked from commit 28233f9a943f9c6c67d4934cf693869c9c03b1e4)
    (cherry picked from commit ecaf8010fc6ee2e28e6a0f05cb2ae0a8ce25b5e6)
    (cherry picked from commit 8c3549d828c5ba0d6306b76494fdbd1abd9d8471)