OpenStack Nova Compute Charm

/etc/nova/nova-compute.conf is overwritten always

Bug #1977803 reported by Nobuto Murata
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Nova Compute Charm
Status tracked in Trunk
2023.1
Fix Released
Undecided
Unassigned
Train
Triaged
High
Unassigned
Trunk
Fix Released
Undecided
Unassigned
Ussuri
Triaged
High
Unassigned
Victoria
Triaged
High
Unassigned
Wallaby
Triaged
High
Unassigned
Xena
Triaged
High
Unassigned
Yoga
Fix Released
Undecided
Unassigned
Zed
Fix Released
Undecided
Unassigned

Bug Description

/etc/nova/nova-compute.conf is offered by packages to have respective "virt_type" based on the hypervisor chosen.

$ apt-file search /etc/nova/nova-compute.conf
nova-compute-ironic: /etc/nova/nova-compute.conf
nova-compute-kvm: /etc/nova/nova-compute.conf
nova-compute-lxc: /etc/nova/nova-compute.conf
nova-compute-qemu: /etc/nova/nova-compute.conf
nova-compute-vmware: /etc/nova/nova-compute.conf
nova-compute-xen: /etc/nova/nova-compute.conf

It was untouched until when Ironic comes into play with templates/train/nova-compute.conf. After that, specifying virt-type=qemu in the charm config no longer works.
https://charmhub.io/nova-compute/configure#virt-type

Those flavors are for testing only though.
> Other native libvirt flavors available for testing only: uml, lxc, qemu.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

Hi Nobuto,

Thanks for reporting this. I think this may have been fixed by https://opendev.org/openstack/charm-nova-compute/commit/f6c536baec29a34b79a13708f2f0b82dd0db0530, but it has only been backported to stable/yoga.

Corey

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/wallaby)

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886147

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/victoria)

Related fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886148

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886149

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886310

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-nova-compute (stable/queens)

Change abandoned by "Corey Bryant <email address hidden>" on branch: stable/queens
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886149

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/ussuri)

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886311

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-nova-compute (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/886147
Committed: https://opendev.org/openstack/charm-nova-compute/commit/9e93bcd051f41ce0403c4e136fe54eee56c655bd
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9e93bcd051f41ce0403c4e136fe54eee56c655bd
Author: Billy Olsen <email address hidden>
Date: Tue Apr 19 20:00:02 2022 -0700

    Render correct driver in nova-compute.conf

    Commit abe5a289 fixed the rendering of the ironic driver in the
    nova-compute.conf file for OpenStack versions >= Wallaby. However, it
    always renders the nova-compute.conf file for train and above, which is
    hard-coded to the Ironic libvirt driver.

    This adds additional templating logic to the nova-compute.conf driver in
    order to render the correct driver to use.

    Related-Bug: #1968547
    Related-Bug: #1977803
    Change-Id: I12cd4bf5953170d227d52793764c49f3871e25f9
    (cherry picked from commit f6c536baec29a34b79a13708f2f0b82dd0db0530)
    (cherry picked from commit 7f3fb79210857e40b58d6c61ed35a7ee4ac18030)

tags: added: in-stable-wallaby
tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-nova-compute (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/886146
Committed: https://opendev.org/openstack/charm-nova-compute/commit/4ce723fd707adeaddb9aa98d0e5a9f41fd930614
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 4ce723fd707adeaddb9aa98d0e5a9f41fd930614
Author: Billy Olsen <email address hidden>
Date: Tue Apr 19 20:00:02 2022 -0700

    Render correct driver in nova-compute.conf

    Commit abe5a289 fixed the rendering of the ironic driver in the
    nova-compute.conf file for OpenStack versions >= Wallaby. However, it
    always renders the nova-compute.conf file for train and above, which is
    hard-coded to the Ironic libvirt driver.

    This adds additional templating logic to the nova-compute.conf driver in
    order to render the correct driver to use.

    Related-Bug: #1968547
    Related-Bug: #1977803
    Change-Id: I12cd4bf5953170d227d52793764c49f3871e25f9
    (cherry picked from commit f6c536baec29a34b79a13708f2f0b82dd0db0530)
    (cherry picked from commit 7f3fb79210857e40b58d6c61ed35a7ee4ac18030)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-nova-compute (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/886148
Committed: https://opendev.org/openstack/charm-nova-compute/commit/133801b294985adaa246520eaa90f3e2b2285c6d
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 133801b294985adaa246520eaa90f3e2b2285c6d
Author: Billy Olsen <email address hidden>
Date: Tue Apr 19 20:00:02 2022 -0700

    Render correct driver in nova-compute.conf

    Commit abe5a289 fixed the rendering of the ironic driver in the
    nova-compute.conf file for OpenStack versions >= Wallaby. However, it
    always renders the nova-compute.conf file for train and above, which is
    hard-coded to the Ironic libvirt driver.

    This adds additional templating logic to the nova-compute.conf driver in
    order to render the correct driver to use.

    Related-Bug: #1968547
    Related-Bug: #1977803
    Change-Id: I12cd4bf5953170d227d52793764c49f3871e25f9
    (cherry picked from commit f6c536baec29a34b79a13708f2f0b82dd0db0530)
    (cherry picked from commit 7f3fb79210857e40b58d6c61ed35a7ee4ac18030)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-nova-compute (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/886311
Committed: https://opendev.org/openstack/charm-nova-compute/commit/d58560b64f1529f47192138ad2cce29bc6e42362
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit d58560b64f1529f47192138ad2cce29bc6e42362
Author: Billy Olsen <email address hidden>
Date: Tue Apr 19 20:00:02 2022 -0700

    Render correct driver in nova-compute.conf

    Commit abe5a289 fixed the rendering of the ironic driver in the
    nova-compute.conf file for OpenStack versions >= Wallaby. However, it
    always renders the nova-compute.conf file for train and above, which is
    hard-coded to the Ironic libvirt driver.

    This adds additional templating logic to the nova-compute.conf driver in
    order to render the correct driver to use.

    Related-Bug: #1968547
    Related-Bug: #1977803
    Change-Id: I12cd4bf5953170d227d52793764c49f3871e25f9
    (cherry picked from commit f6c536baec29a34b79a13708f2f0b82dd0db0530)
    (cherry picked from commit 7f3fb79210857e40b58d6c61ed35a7ee4ac18030)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-nova-compute (stable/train)

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886310
Reason: Train is about to transition to End of Life. Open patches needs to be abandoned before branch deletion.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.