vnc console doesnt work in openstack yoga

[Maxim Monin]

nova config generation for vnc options uses [Default] section. But this section is depricated in openstack yoga. Valid config requires generation:
[vnc]
server_proxyclient_address = $my_ip

[Maxim Monin (maximmonin)]

issue was fixed, moved from "stable" version to "yoga/stable" version of charm

[Siarhei Matashuk (m1588)]

I have the same issue also, it seems that with yoga/stable channel of nova-compute charm the nova.conf is rendered using /var/lib/juju/agents/unit-nova-compute-6/charm/templates/train/nova.conf template which is old and has no [vnc] section.

[Alex Kavanagh (ajkavanagh)]

> I have the same issue also, it seems that with yoga/stable channel of nova-compute charm the nova.conf is rendered using /var/lib/juju/agents/unit-nova-compute-6/charm/templates/train/nova.conf template which is old and has no [vnc] section.

Yes, this is an issue. More interestingly, it's due to the (deprecated) vncserver_proxy_address being removed at yoga and only using the server_proxy_address: https://docs.openstack.org/releasenotes/nova/yoga.html#upgrade-notes

For future travellers: move the vnc options into a [vnc] section in a newly created ./templates/yoga/nova.conf.

Fix on master, then backport to stable/yoga branch.

[Alex Kavanagh (ajkavanagh)]

This bug only affects the nova-compute charm; the console isn't provided from the nova-cloud-controller for this particularly setting.

[Jason C. Nucciarone (nuccitheboss)]

Currently working on this bug. However, a new bug has been presented by the zaza openstack tests. For some reason, the tests are failing to retrieve the name of the nova-compute/0 unit.

New bug has been raised against the zaza openstack tests, so once this issue is resolved I should be able to propose my fix for nova-compute. Here is the link to the bug report on the zaza openstack repository: https://github.com/openstack-charmers/zaza-openstack-tests/issues/824.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/850247
Committed: https://opendev.org/openstack/charm-nova-compute/commit/73edc4f817d0a8c281284a0df850d93ea5427014
Submitter: "Zuul (22348)"
Branch: master

commit 73edc4f817d0a8c281284a0df850d93ea5427014
Author: NucciTheBoss <email address hidden>
Date: Mon Jul 18 13:37:42 2022 -0400

    Update nova.conf for OpenStack Yoga

    This merge request focuses on fixing the VNC config for OpenStack Yoga
    on the Focal and Jammy series. Originally, the Yoga version of this
    charm was using a template nova.conf file from Train which did not use
    the new [vnc] required for Yoga. Train had the VNC config in the
    [DEFAULT] section, which is depreciated in Yoga.

    Itemized changes to charm below:

     * Create templates/yoga
     * Move VNC config to [vnc] section in nova.conf
     * Rename VNC config keys to follow the Yoga specification.

    Closes-Bug: #1974082
    Closes-Bug: #1734683

    Change-Id: Ic100528f9f38bbc0c83e4f563166113024e3db59

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/864697

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/864697
Committed: https://opendev.org/openstack/charm-nova-compute/commit/9092d68ae66335c0bf2db75dffdb2731d9165fcd
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 9092d68ae66335c0bf2db75dffdb2731d9165fcd
Author: NucciTheBoss <email address hidden>
Date: Mon Jul 18 13:37:42 2022 -0400

    Update nova.conf for OpenStack Yoga

    This merge request focuses on fixing the VNC config for OpenStack Yoga
    on the Focal and Jammy series. Originally, the Yoga version of this
    charm was using a template nova.conf file from Train which did not use
    the new [vnc] required for Yoga. Train had the VNC config in the
    [DEFAULT] section, which is depreciated in Yoga.

    Itemized changes to charm below:

     * Create templates/yoga
     * Move VNC config to [vnc] section in nova.conf
     * Rename VNC config keys to follow the Yoga specification.

    Closes-Bug: #1974082
    Closes-Bug: #1734683

    Change-Id: Ic100528f9f38bbc0c83e4f563166113024e3db59
    (cherry picked from commit 73edc4f817d0a8c281284a0df850d93ea5427014)