OpenStack Nova Compute Charm

Charm fails on victoria+ with virt-type ironic

Bug #1968547 reported by Liam Young
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Nova Compute Charm
Fix Released
High
Liam Young
OpenStack Nova Compute Charm 22.04

Bug Description

When virt-type is set to `ironic` the charm fails trying to install qemu.conf. This appears to be caused by recent change https://review.opendev.org/c/openstack/charm-nova-compute/+/825420

When the nova-compute charm is deployed with the virt type of `ironic` it does not run a local hypervisor but rather acts as a proxy for starting up baremetal machines. As such, it does not need to render the qemu.conf and does not install the packages that precreate `/etc/libvirt/`.

If kvm is the virt type then the charm installs `nova-compute-kvm`. The package dependancies triggers `libvirt-daemon-system` to be installed which triggers the `/etc/libvirt/` directory to be created. In contrast the if the virt type is set to ironic then `libvirt-daemon-system` is not a dependancy and the directory is missing.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-nova-compute (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/837288

Changed in charm-nova-compute:
status: New → In Progress
Liam Young (gnuoy)
Changed in charm-nova-compute:
assignee: nobody → Liam Young (gnuoy)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-nova-compute (master)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/837288
Committed: https://opendev.org/openstack/charm-nova-compute/commit/abe5a289eded4cd59c7a834f68433d0416464b8a
Submitter: "Zuul (22348)"
Branch: master

commit abe5a289eded4cd59c7a834f68433d0416464b8a
Author: Liam Young <email address hidden>
Date: Mon Apr 11 10:37:24 2022 +0000

    Only render qemu.conf for hypervisors using qemu

    Change-Id: I02a250c27d1b52d5cc9df3f1d6256bfc3ab982ea
    Closes-Bug: #1968547

Changed in charm-nova-compute:
status: In Progress → Fix Committed
Alex Kavanagh (ajkavanagh)
Changed in charm-nova-compute:
milestone: none → 22.04
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/838622

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-nova-compute (master)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/838622
Committed: https://opendev.org/openstack/charm-nova-compute/commit/f6c536baec29a34b79a13708f2f0b82dd0db0530
Submitter: "Zuul (22348)"
Branch: master

commit f6c536baec29a34b79a13708f2f0b82dd0db0530
Author: Billy Olsen <email address hidden>
Date: Tue Apr 19 20:00:02 2022 -0700

    Render correct driver in nova-compute.conf

    Commit abe5a289 fixed the rendering of the ironic driver in the
    nova-compute.conf file for OpenStack versions >= Wallaby. However, it
    always renders the nova-compute.conf file for train and above, which is
    hard-coded to the Ironic libvirt driver.

    This adds additional templating logic to the nova-compute.conf driver in
    order to render the correct driver to use.

    Related-Bug: #1968547
    Change-Id: I12cd4bf5953170d227d52793764c49f3871e25f9

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/yoga)

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/838694

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-nova-compute (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/838694
Committed: https://opendev.org/openstack/charm-nova-compute/commit/7f3fb79210857e40b58d6c61ed35a7ee4ac18030
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 7f3fb79210857e40b58d6c61ed35a7ee4ac18030
Author: Billy Olsen <email address hidden>
Date: Tue Apr 19 20:00:02 2022 -0700

    Render correct driver in nova-compute.conf

    Commit abe5a289 fixed the rendering of the ironic driver in the
    nova-compute.conf file for OpenStack versions >= Wallaby. However, it
    always renders the nova-compute.conf file for train and above, which is
    hard-coded to the Ironic libvirt driver.

    This adds additional templating logic to the nova-compute.conf driver in
    order to render the correct driver to use.

    Related-Bug: #1968547
    Change-Id: I12cd4bf5953170d227d52793764c49f3871e25f9
    (cherry picked from commit f6c536baec29a34b79a13708f2f0b82dd0db0530)

tags: added: in-stable-yoga
Alex Kavanagh (ajkavanagh)
Changed in charm-nova-compute:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/xena)

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886146

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/wallaby)

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886147

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/victoria)

Related fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886148

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886149

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886310

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-nova-compute (stable/queens)

Change abandoned by "Corey Bryant <email address hidden>" on branch: stable/queens
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886149

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-nova-compute (stable/ussuri)

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886311

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-nova-compute (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/886147
Committed: https://opendev.org/openstack/charm-nova-compute/commit/9e93bcd051f41ce0403c4e136fe54eee56c655bd
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9e93bcd051f41ce0403c4e136fe54eee56c655bd
Author: Billy Olsen <email address hidden>
Date: Tue Apr 19 20:00:02 2022 -0700

    Render correct driver in nova-compute.conf

    Commit abe5a289 fixed the rendering of the ironic driver in the
    nova-compute.conf file for OpenStack versions >= Wallaby. However, it
    always renders the nova-compute.conf file for train and above, which is
    hard-coded to the Ironic libvirt driver.

    This adds additional templating logic to the nova-compute.conf driver in
    order to render the correct driver to use.

    Related-Bug: #1968547
    Related-Bug: #1977803
    Change-Id: I12cd4bf5953170d227d52793764c49f3871e25f9
    (cherry picked from commit f6c536baec29a34b79a13708f2f0b82dd0db0530)
    (cherry picked from commit 7f3fb79210857e40b58d6c61ed35a7ee4ac18030)

tags: added: in-stable-wallaby
tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-nova-compute (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/886146
Committed: https://opendev.org/openstack/charm-nova-compute/commit/4ce723fd707adeaddb9aa98d0e5a9f41fd930614
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 4ce723fd707adeaddb9aa98d0e5a9f41fd930614
Author: Billy Olsen <email address hidden>
Date: Tue Apr 19 20:00:02 2022 -0700

    Render correct driver in nova-compute.conf

    Commit abe5a289 fixed the rendering of the ironic driver in the
    nova-compute.conf file for OpenStack versions >= Wallaby. However, it
    always renders the nova-compute.conf file for train and above, which is
    hard-coded to the Ironic libvirt driver.

    This adds additional templating logic to the nova-compute.conf driver in
    order to render the correct driver to use.

    Related-Bug: #1968547
    Related-Bug: #1977803
    Change-Id: I12cd4bf5953170d227d52793764c49f3871e25f9
    (cherry picked from commit f6c536baec29a34b79a13708f2f0b82dd0db0530)
    (cherry picked from commit 7f3fb79210857e40b58d6c61ed35a7ee4ac18030)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-nova-compute (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/886148
Committed: https://opendev.org/openstack/charm-nova-compute/commit/133801b294985adaa246520eaa90f3e2b2285c6d
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 133801b294985adaa246520eaa90f3e2b2285c6d
Author: Billy Olsen <email address hidden>
Date: Tue Apr 19 20:00:02 2022 -0700

    Render correct driver in nova-compute.conf

    Commit abe5a289 fixed the rendering of the ironic driver in the
    nova-compute.conf file for OpenStack versions >= Wallaby. However, it
    always renders the nova-compute.conf file for train and above, which is
    hard-coded to the Ironic libvirt driver.

    This adds additional templating logic to the nova-compute.conf driver in
    order to render the correct driver to use.

    Related-Bug: #1968547
    Related-Bug: #1977803
    Change-Id: I12cd4bf5953170d227d52793764c49f3871e25f9
    (cherry picked from commit f6c536baec29a34b79a13708f2f0b82dd0db0530)
    (cherry picked from commit 7f3fb79210857e40b58d6c61ed35a7ee4ac18030)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-nova-compute (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/886311
Committed: https://opendev.org/openstack/charm-nova-compute/commit/d58560b64f1529f47192138ad2cce29bc6e42362
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit d58560b64f1529f47192138ad2cce29bc6e42362
Author: Billy Olsen <email address hidden>
Date: Tue Apr 19 20:00:02 2022 -0700

    Render correct driver in nova-compute.conf

    Commit abe5a289 fixed the rendering of the ironic driver in the
    nova-compute.conf file for OpenStack versions >= Wallaby. However, it
    always renders the nova-compute.conf file for train and above, which is
    hard-coded to the Ironic libvirt driver.

    This adds additional templating logic to the nova-compute.conf driver in
    order to render the correct driver to use.

    Related-Bug: #1968547
    Related-Bug: #1977803
    Change-Id: I12cd4bf5953170d227d52793764c49f3871e25f9
    (cherry picked from commit f6c536baec29a34b79a13708f2f0b82dd0db0530)
    (cherry picked from commit 7f3fb79210857e40b58d6c61ed35a7ee4ac18030)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-nova-compute (stable/train)

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/886310
Reason: Train is about to transition to End of Life. Open patches needs to be abandoned before branch deletion.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.