No dedicated charm option to specify reserved_host_disk_mb

Bug #1952184 reported by Nobuto Murata
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Charm Guide
Fix Released
Undecided
Unassigned
OpenStack Nova Compute Charm
Fix Released
Undecided
Unassigned

Bug Description

The charm has "reserved-host-memory" and "reserved-huge-pages" exposed as dedicated charm options.
https://jaas.ai/nova-compute#charm-config-reserved-host-memory
https://jaas.ai/nova-compute#charm-config-reserved-huge-pages

However, there is no dedicated option to expose "reserved_host_disk_mb".
https://github.com/openstack/nova/blob/75f719e022ab43b2f66f7e5a487742ddd8e4aa74/nova/conf/compute.py#L365-L378

Just to clarify reserved_host_cpus doesn't need to be exposed since it's mutually exclusive with cpu_shared_set and cpu_dedicated_set which are already exposed as charm options.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-nova-compute (master)
Changed in charm-nova-compute:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-nova-compute (master)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/819255
Committed: https://opendev.org/openstack/charm-nova-compute/commit/a5dc16393ad94d9029a5de1605177d14f57f1af9
Submitter: "Zuul (22348)"
Branch: master

commit a5dc16393ad94d9029a5de1605177d14f57f1af9
Author: Nobuto Murata <email address hidden>
Date: Thu Nov 25 15:44:48 2021 +0900

    Expose reserved_host_disk_mb for nova.conf

    The config is necessary to calculate available disk space for VMs with
    disk-allocation-ratio which is already exposed as a charm option.

    Closes-Bug: #1952184
    Change-Id: I0ef55987517bded50f855e0dbc5e420cfbff4c1b

Changed in charm-nova-compute:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-nova-compute (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/836417

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-nova-compute (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charm-nova-compute/+/836417
Committed: https://opendev.org/openstack/charm-nova-compute/commit/b5cc605b66f2fc2155bb09462429cd7b06a41bc9
Submitter: "Zuul (22348)"
Branch: stable/xena

commit b5cc605b66f2fc2155bb09462429cd7b06a41bc9
Author: Nobuto Murata <email address hidden>
Date: Thu Nov 25 15:44:48 2021 +0900

    Expose reserved_host_disk_mb for nova.conf

    The config is necessary to calculate available disk space for VMs with
    disk-allocation-ratio which is already exposed as a charm option.

    Closes-Bug: #1952184
    Change-Id: I0ef55987517bded50f855e0dbc5e420cfbff4c1b
    (cherry picked from commit a5dc16393ad94d9029a5de1605177d14f57f1af9)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-guide (master)
Changed in charm-guide:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-guide (master)

Reviewed: https://review.opendev.org/c/openstack/charm-guide/+/837654
Committed: https://opendev.org/openstack/charm-guide/commit/92aafabfe0fcfb092ef6966cbebc5877e6c22848
Submitter: "Zuul (22348)"
Branch: master

commit 92aafabfe0fcfb092ef6966cbebc5877e6c22848
Author: Nobuto Murata <email address hidden>
Date: Wed Apr 13 11:57:42 2022 +0900

    release-notes: reserved-host-disk

    Closes-Bug: #1952184
    Change-Id: I90a1ba83293b795f0b99e2fbc756d5cbfc70a300

Changed in charm-guide:
status: In Progress → Fix Released
Changed in charm-nova-compute:
milestone: none → 22.04
Changed in charm-nova-compute:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.