Feature request: Allow nova to publish versioned notification messages

[Ed Stewart]

This is a feature request to update the nova charm so that it configures nova.conf to emit versioned notifications as well as unversioned and for the log driver to be added as a sink.

We understand that the unversioned versions are being picked up by Ceilometer, and that versioned were turned off because there was no rabbitmq subscriber to those events and thus they would stay on the messaging queue forever. We understand that a TTL has now been implemented in rabbitmq so that these messages will be gracefully discarded.

The combination of adding versioned notifications and writing these to nova log files will allow us to implement logic in Graylog to detect VM events such as startup/shutdown through consolidated logs.

This configuration worked successfully in our testing:

[notifications]
notification_format = both

[oslo_messaging_notifications]
driver = messagingv2
transport_url = rabbit://nova:OBFUSCATED@252.5.22.173:5672/openstack
driver = log

[Sahid Orentino (sahid-ferdjaoui)]

There is a section-oslo-notifications [0] section in the template of nova.conf [1] which should do exactly what you are looking for I guess. I'm trying to figure out the right config.

[0] https://github.com/openstack/charm-nova-compute/blob/master/hooks/charmhelpers/contrib/openstack/templates/section-oslo-notifications
[1] https://github.com/openstack/charm-nova-compute/blob/master/templates/rocky/nova.conf#L275

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/653945

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/655641

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/655641
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=089823288a23d73f2c86f9dd261b3d3ff9cebfea
Submitter: Zuul
Branch: master

commit 089823288a23d73f2c86f9dd261b3d3ff9cebfea
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Thu Apr 25 11:30:22 2019 +0200

    charm-helpers: sync the last changes merged

    The last PR merged in charm-helpers introduce two new config
    notifications-format and oslo-messaging-driver.

    Change-Id: I4899df0d2badc0d8d633bc9bcce41a06dc4d9591
    Related-Bug: 1825016
    Signed-off-by: Sahid Orentino Ferdjaoui <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/653945
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=599245bbd16bb986e43d753857e73da2555fc77b
Submitter: Zuul
Branch: master

commit 599245bbd16bb986e43d753857e73da2555fc77b
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Fri Apr 19 15:30:51 2019 +0200

    config: add notification-format option

    This require a change in charm-helper:
      https://github.com/juju/charm-helpers/pull/310/

    Related-Bug: 1825016
    Signed-off-by: Sahid Orentino Ferdjaoui <email address hidden>
    Change-Id: I7887b5f06e194450ec69d8adc5d6fd7f84fee6fe

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/659241

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/659241
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=3a15dd83494341d754b261e937a7354b191f6a00
Submitter: Zuul
Branch: master

commit 3a15dd83494341d754b261e937a7354b191f6a00
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Fri May 17 09:36:40 2019 +0000

    config: expose send-notifications-to-logs options

    The last version of charmhelpers introduces ability to set additional
    driver which enable notfications to be sent to system logs.

    Depends-of: https://github.com/juju/charm-helpers/pull/323
    Closes-bug: 1825016
    Change-Id: Ibe84826060922671e7fc160734d5ae3974d663ed
    Signed-off-by: Sahid Orentino Ferdjaoui <email address hidden>