Pre-install script does not fail on error in install hook

Bug #1815243 reported by Ryan Beisner on 2019-02-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Ceph-FS Charm
Undecided
Ryan Beisner
OpenStack LXD Charm
Medium
Ryan Beisner
OpenStack Nova Compute Proxy Charm
Wishlist
Unassigned
OpenStack Tempest Charm
Low
Ryan Beisner
OpenStack ceilometer charm
Medium
Ryan Beisner
OpenStack ceilometer-agent charm
Medium
Ryan Beisner
OpenStack ceph-mon charm
High
Ryan Beisner
OpenStack ceph-osd charm
High
Ryan Beisner
OpenStack ceph-radosgw charm
High
Ryan Beisner
OpenStack cinder charm
Medium
Ryan Beisner
OpenStack cinder-ceph charm
Medium
Ryan Beisner
OpenStack glance charm
Medium
Ryan Beisner
OpenStack glance-simplestreams-sync charm
Medium
Ryan Beisner
OpenStack hacluster charm
Medium
Ryan Beisner
OpenStack heat charm
Medium
Ryan Beisner
OpenStack keystone charm
High
Ryan Beisner
OpenStack nova-cloud-controller charm
Medium
Ryan Beisner
OpenStack nova-compute charm
Medium
Ryan Beisner
OpenStack openstack-dashboard charm
Medium
Ryan Beisner
OpenStack percona-cluster charm
High
Ryan Beisner
OpenStack rabbitmq-server charm
High
Ryan Beisner
OpenStack swift-proxy charm
Medium
Ryan Beisner
OpenStack swift-storage charm
Medium
Ryan Beisner

Bug Description

The pre-install operations may fail, yet that failure is not elevated to the user. This masks the failure and makes early package install issues difficult to troubleshoot.

If the basic pre-install script fails, the charm should not proceed to later hooks as the requirements may not be met.

Hashbangs for bash should specify -e (errexit) on all of the pre-install bash scripts.

Ryan Beisner (1chb1n) on 2019-02-08
Changed in charm-ceph-fs:
assignee: nobody → Ryan Beisner (1chb1n)
Changed in charm-ceph-mon:
assignee: nobody → Ryan Beisner (1chb1n)
Changed in charm-ceph-osd:
assignee: nobody → Ryan Beisner (1chb1n)
Changed in charm-ceph-radosgw:
assignee: nobody → Ryan Beisner (1chb1n)
Changed in charm-ceph-fs:
status: New → In Progress
Changed in charm-ceph-mon:
status: New → In Progress
Changed in charm-ceph-osd:
status: New → In Progress
Changed in charm-ceph-radosgw:
status: New → In Progress
Changed in charm-ceph-fs:
importance: Undecided → High
Changed in charm-ceph-mon:
importance: Undecided → High
Changed in charm-ceph-osd:
importance: Undecided → High
Changed in charm-ceph-radosgw:
importance: Undecided → High
Changed in charm-ceph-fs:
milestone: none → 19.04
Changed in charm-ceph-mon:
milestone: none → 19.04
Changed in charm-ceph-osd:
milestone: none → 19.04
Changed in charm-ceph-radosgw:
milestone: none → 19.04
summary: - charm-ceph-radosgw
+ Pre-install hook does not fail on error
summary: - Pre-install hook does not fail on error
+ Pre-install script does not fail on error in install hook
Ryan Beisner (1chb1n) on 2019-02-08
Changed in charm-swift-proxy:
status: New → In Progress
Changed in charm-swift-storage:
status: New → In Progress
Changed in charm-swift-proxy:
importance: Undecided → Medium
Changed in charm-swift-storage:
importance: Undecided → Medium
Changed in charm-swift-proxy:
assignee: nobody → Ryan Beisner (1chb1n)
Changed in charm-swift-storage:
assignee: nobody → Ryan Beisner (1chb1n)
Changed in charm-swift-proxy:
milestone: none → 19.04
Changed in charm-swift-storage:
milestone: none → 19.04
Changed in charm-ceilometer:
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress
assignee: nobody → Ryan Beisner (1chb1n)
Changed in charm-ceilometer-agent:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress
Changed in charm-cinder:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress
Changed in charm-cinder-ceph:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress
Ryan Beisner (1chb1n) on 2019-02-08
Changed in charm-glance:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress
Changed in charm-glance-simplestreams-sync:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress
Changed in charm-heat:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress

Change abandoned by David Ames (<email address hidden>) on branch: master
Review: https://review.openstack.org/635968
Reason: Duplicate

Ryan Beisner (1chb1n) on 2019-02-08
Changed in charm-ceph-fs:
importance: High → Undecided
milestone: 19.04 → none
status: In Progress → Invalid
Changed in charm-nova-compute-proxy:
importance: Undecided → Wishlist
status: New → Won't Fix
Changed in charm-lxd:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress
Ryan Beisner (1chb1n) on 2019-02-08
Changed in charm-tempest:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Low
milestone: none → 19.04
status: New → In Progress
Changed in charm-hacluster:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress
Changed in charm-keystone:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → High
milestone: none → 19.04
status: New → In Progress
Changed in charm-nova-cloud-controller:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress
Changed in charm-nova-compute:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress
Changed in charm-openstack-dashboard:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → Medium
milestone: none → 19.04
status: New → In Progress
Changed in charm-percona-cluster:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → High
milestone: none → 19.04
status: New → In Progress
Changed in charm-rabbitmq-server:
assignee: nobody → Ryan Beisner (1chb1n)
importance: Undecided → High
milestone: none → 19.04
status: New → In Progress

Reviewed: https://review.openstack.org/635954
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=8b2c46cff7035db47af8ca344feaebd4ebac6633
Submitter: Zuul
Branch: master

commit 8b2c46cff7035db47af8ca344feaebd4ebac6633
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:49:27 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: Iac27d10d928bd0cca60a52564fab4d8082ca1edb
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-glance:
status: In Progress → Fix Committed
Changed in charm-cinder-ceph:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635950
Committed: https://git.openstack.org/cgit/openstack/charm-cinder-ceph/commit/?id=d3cfc3ff1300175674338ebc6cafb2225e5bee59
Submitter: Zuul
Branch: master

commit d3cfc3ff1300175674338ebc6cafb2225e5bee59
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:48:16 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: I67b3a965b11844a2768800225396927f17864116
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-swift-storage:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635946
Committed: https://git.openstack.org/cgit/openstack/charm-swift-storage/commit/?id=30466da23da2b962280ccbd5c2438080db77b49f
Submitter: Zuul
Branch: master

commit 30466da23da2b962280ccbd5c2438080db77b49f
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:41:22 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: Ie2a9e473e35eb8067db2890c62b4af9adce3ed43
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-hacluster:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635955
Committed: https://git.openstack.org/cgit/openstack/charm-hacluster/commit/?id=84ca05beb859f75268d25a986ef189fd8924ece5
Submitter: Zuul
Branch: master

commit 84ca05beb859f75268d25a986ef189fd8924ece5
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:50:27 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: I4e03103789100aca944ad79d2e59abfa6a65ab3f
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-ceilometer:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635947
Committed: https://git.openstack.org/cgit/openstack/charm-ceilometer/commit/?id=554bf0af8eb2e6738cc078a7ae8440c61ecc0b04
Submitter: Zuul
Branch: master

commit 554bf0af8eb2e6738cc078a7ae8440c61ecc0b04
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:46:19 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: Ibea69c2280c58f995152330f8a60f7d1babcf549
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-cinder:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635949
Committed: https://git.openstack.org/cgit/openstack/charm-cinder/commit/?id=9eb22b894914f36da8ceaa71eb243e465b6a9731
Submitter: Zuul
Branch: master

commit 9eb22b894914f36da8ceaa71eb243e465b6a9731
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:47:41 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: I3e421d586df341113bbcd1888f280a2ea24c52b9
    Closes-bug: #1815243
    Partial-bug: #1815231

Reviewed: https://review.openstack.org/635959
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=3edfdfd152a106fb5a3a5a27db5b28e39655b52f
Submitter: Zuul
Branch: master

commit 3edfdfd152a106fb5a3a5a27db5b28e39655b52f
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:55:36 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: Ie6c8f84dc72802897d3a9c9fab6a57953d5eb2f8
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-nova-cloud-controller:
status: In Progress → Fix Committed
Changed in charm-heat:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635956
Committed: https://git.openstack.org/cgit/openstack/charm-heat/commit/?id=2b6943ddad5d572329391d7b88ba2d5173c044d1
Submitter: Zuul
Branch: master

commit 2b6943ddad5d572329391d7b88ba2d5173c044d1
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:50:56 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: Ibadb518bfccc3e6a83ec054fc1fb5b1cac096d33
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-lxd:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635958
Committed: https://git.openstack.org/cgit/openstack/charm-lxd/commit/?id=2996db663ffe78ef4754233f9ab565cc92551c9c
Submitter: Zuul
Branch: master

commit 2996db663ffe78ef4754233f9ab565cc92551c9c
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:52:13 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: I6178e2cb6665b7a4bdbe66a63b29616067932352
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-percona-cluster:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635961
Committed: https://git.openstack.org/cgit/openstack/charm-percona-cluster/commit/?id=3ca3cd3f870fd28f29c4cee12ca456e6d76b9a8f
Submitter: Zuul
Branch: master

commit 3ca3cd3f870fd28f29c4cee12ca456e6d76b9a8f
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:56:46 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: I9f6990cc8601abb703e27a56c4cb243245031234
    Closes-bug: #1815243
    Partial-bug: #1815231

Reviewed: https://review.openstack.org/635963
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=56358d1d335bc59ad6af4fed675119ceb95a6ef9
Submitter: Zuul
Branch: master

commit 56358d1d335bc59ad6af4fed675119ceb95a6ef9
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:58:48 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: If36f0df0a8be40c82cf2244584e9531ada005c92
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-openstack-dashboard:
status: In Progress → Fix Committed
Changed in charm-nova-compute:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635960
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=6868b47b3e67f17009651742a84e17de3fc7f41f
Submitter: Zuul
Branch: master

commit 6868b47b3e67f17009651742a84e17de3fc7f41f
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:56:12 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: I5532e6468fe4a9caffab81f890ab245bf441dfd4
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-glance-simplestreams-sync:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635967
Committed: https://git.openstack.org/cgit/openstack/charm-glance-simplestreams-sync/commit/?id=d597eaedbb672c68b3c730ba4c039db9e4cdeaec
Submitter: Zuul
Branch: master

commit d597eaedbb672c68b3c730ba4c039db9e4cdeaec
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:49:58 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: I61301f3ed953f685bca3c4060907ccda8cec6f49
    Closes-bug: #1815243
    Partial-bug: #1815231

Reviewed: https://review.openstack.org/635962
Committed: https://git.openstack.org/cgit/openstack/charm-rabbitmq-server/commit/?id=0e35fadab38f4a4b1ff30a821100f8481f7491f4
Submitter: Zuul
Branch: master

commit 0e35fadab38f4a4b1ff30a821100f8481f7491f4
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:57:16 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: Ib9bc7a096972bac1b91d53d662b5f0469d9e0ffe
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-rabbitmq-server:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635942
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=f1fffb788517b829b537000b75667724cce24efc
Submitter: Zuul
Branch: master

commit f1fffb788517b829b537000b75667724cce24efc
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:35:02 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: If6ddd58fc6aeb1e9bf359a037a85a2ce2ae05d3c
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-ceph-osd:
status: In Progress → Fix Committed
Changed in charm-swift-proxy:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635945
Committed: https://git.openstack.org/cgit/openstack/charm-swift-proxy/commit/?id=5e2ed7f212686f4ef1eb19e04c41dc421fcbc593
Submitter: Zuul
Branch: master

commit 5e2ed7f212686f4ef1eb19e04c41dc421fcbc593
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:40:14 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: I0f41092fac7259863c215505ca305ff92cfae69a
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-ceph-mon:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635937
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-mon/commit/?id=be74c0fd1c6ebfc4d5da1f6e583abc8047438e0c
Submitter: Zuul
Branch: master

commit be74c0fd1c6ebfc4d5da1f6e583abc8047438e0c
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:28:41 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: I6e015c2e0a28f9b990bfd7b84a2317d339abbb4e
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-ceph-radosgw:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635940
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-radosgw/commit/?id=c4e5565799fa761494cce96f75e5baca10da290f
Submitter: Zuul
Branch: master

commit c4e5565799fa761494cce96f75e5baca10da290f
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:10:21 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: Ie7b99dfa4cbe00a03acf1b2cc2eeecc7f84fbe17
    Closes-bug: #1815243
    Partial-bug: #1815231

Reviewed: https://review.openstack.org/635957
Committed: https://git.openstack.org/cgit/openstack/charm-keystone/commit/?id=6f7c61c488f1f8d886c3579bde0c950da18f3508
Submitter: Zuul
Branch: master

commit 6f7c61c488f1f8d886c3579bde0c950da18f3508
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:51:32 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: Ib97cbea15c746ac93a6cf6056da2e8d6eb28af3c
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-keystone:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/635948
Committed: https://git.openstack.org/cgit/openstack/charm-ceilometer-agent/commit/?id=058cd81d400cf443070043a55802d3e8684291b8
Submitter: Zuul
Branch: master

commit 058cd81d400cf443070043a55802d3e8684291b8
Author: Ryan Beisner <email address hidden>
Date: Fri Feb 8 15:46:55 2019 -0600

    Update pre-install hooks to fail on error

    The pre-install operations may fail, yet that failure is not
    elevated to the user. This masks the failure and makes early
    package install issues difficult to troubleshoot.

    If the basic pre-install script fails, the charm should not
    proceed to later hooks as the requirements may not be met.

    Hashbangs for bash should specify -e (errexit) on all of the
    pre-install bash scripts.

    Change-Id: I40fedc011933cbce6215dd124019d251b6dafd61
    Closes-bug: #1815243
    Partial-bug: #1815231

Changed in charm-ceilometer-agent:
status: In Progress → Fix Committed
David Ames (thedac) on 2019-04-17
Changed in charm-ceph-radosgw:
status: Fix Committed → Fix Released
Changed in charm-ceph-mon:
status: Fix Committed → Fix Released
Changed in charm-ceph-osd:
status: Fix Committed → Fix Released
Changed in charm-keystone:
status: Fix Committed → Fix Released
Changed in charm-rabbitmq-server:
status: Fix Committed → Fix Released
Changed in charm-percona-cluster:
status: Fix Committed → Fix Released
Changed in charm-swift-proxy:
status: Fix Committed → Fix Released
Changed in charm-swift-storage:
status: Fix Committed → Fix Released
Changed in charm-ceilometer:
status: Fix Committed → Fix Released
Changed in charm-cinder:
status: Fix Committed → Fix Released
Changed in charm-cinder-ceph:
status: Fix Committed → Fix Released
Changed in charm-ceilometer-agent:
status: Fix Committed → Fix Released
Changed in charm-heat:
status: Fix Committed → Fix Released
Changed in charm-glance:
status: Fix Committed → Fix Released
Changed in charm-glance-simplestreams-sync:
status: Fix Committed → Fix Released
Changed in charm-lxd:
status: Fix Committed → Fix Released
Changed in charm-nova-cloud-controller:
status: Fix Committed → Fix Released
Changed in charm-nova-compute:
status: Fix Committed → Fix Released
Changed in charm-hacluster:
status: Fix Committed → Fix Released
Changed in charm-openstack-dashboard:
status: Fix Committed → Fix Released
David Ames (thedac) on 2019-04-17
Changed in charm-tempest:
milestone: 19.04 → 19.07
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers