upgrade from Stein to Train does not remove NRPE check for nova-consoleauth

[Xav Paice]

When upgrading a cloud from bionic-stein to bionic-train, charm cs:nova-cloud-controller-348, the NRPE check for the nova-consoleauth.service service status is not removed, resulting in 'Critical' alerts for a service that was actually removed from the system as part of the upgrade.

[Paul Goins (vultaire)]

Workaround:

unit=<ncc-unit-id>
# Dump current relation data in case something
juju exec -u $unit 'relation-get -r $(relation-ids nrpe-external-master) - '$unit
# Rewrite the monitors field, dropping the nova-consoleauth line
juju exec -u $unit 'echo "monitors: |" >> relation_fix.yaml; rel_id=$(relation-ids nrpe-external-master); relation-get -r $rel_id monitors '$unit' | awk "!/nova-consoleauth/" | sed -e "s/^/ /" >> relation_fix.yaml; relation-set -r $rel_id --file relation_fix.yaml; rm relation_fix.yaml'
# Re-dump relation data to confirm it got rewritten as desired
juju exec -u $unit 'relation-get -r $(relation-ids nrpe-external-master) - '$unit

[Paul Goins (vultaire)]

It looks like there's a remove_deprecated_checks helper method (in charmhelpers I think?), but it never gets called with regard to nova-consoleauth.

[Gábor Mészáros (gabor.meszaros)]

still hitting this issue during upgrades (from Queens, through R/S/T to Ussuri)

[Gábor Mészáros (gabor.meszaros)]

same seems to apply to the nova-api-os-compute.service lack of removal. The apache service gets disabled, but the nrpe check is never revoked from the relations (Rocky onwards).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-nova-cloud-controller/+/822201

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-nova-cloud-controller/+/822201
Committed: https://opendev.org/openstack/charm-nova-cloud-controller/commit/bebed44c3bace64838500e6438502eec1f9fef85
Submitter: "Zuul (22348)"
Branch: master

commit bebed44c3bace64838500e6438502eec1f9fef85
Author: Felipe Reyes <email address hidden>
Date: Fri Dec 17 17:46:51 2021 -0300

    Remove nrpe check of nova-consoleauth when not needed.

    nova-consoleauth was removed for OpenStack >= Train, this change will
    remove the nrpe check associated with it when is_consoleauth_enabled()
    returns False.

    Change-Id: I891634fc8001597089312801b29a80336543f5f0
    Closes-Bug: #1904650