Request: Allow shelving accounting in quotas, by quota.count_usage_from_placement

[Mark Cunningham]

This has been merged upstream as part of Train. This request is to add the configuration options to the Canonical Charmed Openstack version, to allow "SHELVED_OFFLOADED" VMs to not count against quota usage.

Merge Notes
--------------------------------------------------------------------------
https://review.opendev.org/#/c/638073/
----------------------------------------
Count instances from mappings and cores/ram from placement

This counts instance mappings for counting quota usage for instances
and adds calls to placement for counting quota usage for cores and ram.

During an upgrade, if any un-migrated instance mappings are found (with
NULL user_id or NULL queued_for_delete fields), we will fall back to
the legacy counting method.

Counting quota usage from placement is opt-in via the
[quota]count_usage_from_placement configuration option because:

  * Though beneficial for multi-cell deployments to be resilient to
    down cells, the vast majority of deployments are single cell and
    will not be able to realize a down cells resiliency benefit and may
    prefer to keep legacy quota usage counting.

  * Usage for resizes will reflect resources being held on both the
    source and destination until the resize is confirmed or reverted.
    Operators may not want to enable counting from placement based on
    whether the behavior change is problematic for them.

  * Placement does not yet support the ability to partition resource
    providers from mulitple Nova deployments, so environments that are
    sharing a single placement deployment would see usage that
    aggregates all Nova deployments together. Such environments should
    not enable counting from placement.

  * Usage for unscheduled instances in ERROR state will not reflect
    resource consumption for cores and ram because the instance has no
    placement allocations.

  * Usage for instances in SHELVED_OFFLOADED state will not reflect
    resource consumption for cores and ram because the instance has no
    placement allocations. Note that because of this, it will be possible for a
    request to unshelve a server to be rejected if the user does not have
    enough quota available to support the cores and ram needed by the server to
    be unshelved.

Further specification/configuration information
--------------------------------------------------------------------------
https://specs.openstack.org/openstack/nova-specs/specs/train/approved/count-quota-usage-from-placement.html
----------------------------------------

[David Ames (thedac)]

This feature should be enabled as a part of Ussuri enablement.

[Hemanth Nakkina (hemanth-n)]

Fix submitted for review
https://review.opendev.org/#/c/715182/

[Hemanth Nakkina (hemanth-n)]

Test cases verified for https://review.opendev.org/#/c/715182/

[Hemanth Nakkina (hemanth-n)]

Fixes submitted for review
- https://review.opendev.org/#/c/715182/
- https://review.opendev.org/#/c/718681/
- https://github.com/openstack-charmers/zaza-openstack-tests/pull/250

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/715182
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=b5b6966f6dfb7e27c9cfdd7ba13596928ebb8436
Submitter: Zuul
Branch: master

commit b5b6966f6dfb7e27c9cfdd7ba13596928ebb8436
Author: Hemanth Nakkina <email address hidden>
Date: Thu Mar 26 17:40:40 2020 +0530

    Add new config option to set [quota].count_usage_from_placement

    New config option count_usage_from_placement is added in Nova from
    Train release to enable/disable counting of quota usage from placement
    service. Corresponding config parameter is required in nova-cloud-controller
    charm.

    This patch introduces quota-count-usage-from-placement config parameter in
    nova-cloud-controller charm. For openstack releases train or above, this
    option is rendered in nova.conf for nova-cloud-controller units.

    func-test-pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/250
    Change-Id: I57b9335b7b6aecb8610a66a59cb2e4e506e76a5e
    Closes-Bug: #1864859