Problem with host names during ssh-keyscan

[Andrew McLeod]

nova-cloud-controller rev 452 deployed from openstack-charmers-next on eoan on s390x (manual provider)

attempts to keyscan hosts, but uses hostnames such as:

s4lpb
10-13-3-10-internal

these hostnames are correct, and if manually added to /etc/hosts it works, but otherwise should possibly fail more gracefully?

[Alex Kavanagh (ajkavanagh)]

Also relevant: (from irc):

subprocess.CalledProcessError: Command '['ssh-keyscan', '-H', '-t', 'rsa', '10-13-3-11.internal']' returned non-zero exit status 1.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/692331
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=8eca771d02bcc1260797cb1e114384f7f47ca2a2
Submitter: Zuul
Branch: master

commit 8eca771d02bcc1260797cb1e114384f7f47ca2a2
Author: Alex Kavanagh <email address hidden>
Date: Thu Oct 31 10:59:03 2019 +0000

    Ignore ssh-keyscan errors on hosts

    The linked bug is due to a computed shorthost name that is taken as the
    first 'word' in a dotted fqdn provided by rDNS when resolving the IP
    address of a nova-compute host. However, depending on the DNS server,
    this shorthost may not actually exist in the DNS server. This patchset
    ignores ssh-keyscans where effectively the host can't be reached and so
    the shorthost is not added.

    Change-Id: I9ca82e00a79a3eecf37231620f648683edc0bc95
    Closes-Bug: #1849501