TypeError: 'function' object is not scriptable -- at 1259

[Alex Kavanagh]

Reported in #openstack-charms channel by BlackDex:

root@juju-0f4927-0-lxd-13:/var/lib/juju/agents/unit-nova-cloud-controller-0/charm# hooks/config-changed
Traceback (most recent call last):
  File "hooks/config-changed", line 1224, in <module>
    main()
  File "hooks/config-changed", line 1216, in main
    hooks.execute(sys.argv)
  File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/charmhelpers/core/hookenv.py", line 909, in execute
    self._hooks[hook_name]()
  File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/hooks/nova_cc_utils.py", line 1259, in wrapped_f
    for interface in guard_map[svc]:
TypeError: 'function' object is not subscriptable

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/620038

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/620038
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=50a7253b80d5a39cc73fd429979ed4b8dc4bfa54
Submitter: Zuul
Branch: master

commit 50a7253b80d5a39cc73fd429979ed4b8dc4bfa54
Author: Alex Kavanagh <email address hidden>
Date: Mon Nov 26 12:44:01 2018 +0000

    Fix guardmap as a function object issue in service_guard()

    The issue was the original commit had a bug (using the wrong variable),
    and also that there were no tests to verify the functionality. This
    patchset fixes the bug and adds tests to verify the contract.

    Change-Id: Ia8b5580132c5a592461a57fb514994ab64a9ed42
    Closes-Bug: #1805128

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.11
Review: https://review.openstack.org/620137

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/620137
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=0ccb15778defd54f79d1d955d50039082e3fe499
Submitter: Zuul
Branch: stable/18.11

commit 0ccb15778defd54f79d1d955d50039082e3fe499
Author: Alex Kavanagh <email address hidden>
Date: Mon Nov 26 12:44:01 2018 +0000

    Fix guardmap as a function object issue in service_guard()

    The issue was the original commit had a bug (using the wrong variable),
    and also that there were no tests to verify the functionality. This
    patchset fixes the bug and adds tests to verify the contract.

    Closes-Bug: #1805128
    (cherry picked from commit 50a7253b80d5a39cc73fd429979ed4b8dc4bfa54)

    Change-Id: I4c85cf14de2c3b3459330586ec2ffd261fed7a5e