Missing nova-consoleauth package

[Peter Sabaini]

On a 17.02 ncc install the unit is missing the nova-consoleauth package

$ dpkg -l | grep nova-
ii nova-api-os-compute 2:13.1.3-0ubuntu2 all OpenStack Compute - OpenStack Compute API frontend
ii nova-cert 2:13.1.3-0ubuntu2 all OpenStack Compute - certificate management
ii nova-common 2:13.1.3-0ubuntu2 all OpenStack Compute - common files
ii nova-conductor 2:13.1.3-0ubuntu2 all OpenStack Compute - conductor service
ii nova-scheduler 2:13.1.3-0ubuntu2 all OpenStack Compute - virtual machine scheduler

Note this is a HA setup, using memcached and single-nova-consoleauth=True

I have a suspicion that the missing consoleauth package might be due to the fix for bug #1660244, Change-Id: Iaffe0456cceb42ee124cb8881d3379d78cac0f3a

In the above the nova-consoleauth gets removed from the resource_map, but determine_packages() in nova_cc_utils.py uses the resource_map to determine packages for installation

[Jorge Niedbalski (niedbalski)]

Preliminary, I don't think this is direclty related to #1660244 as determine_packages uses the
console_attributes function (https://github.com/openstack/charm-nova-cloud-controller/blob/stable/17.02/hooks/nova_cc_utils.py#L464)

What's your current setting for console-access-protocol?

[Jorge Niedbalski (niedbalski)]

After talking with Peter about this bug, we identified that https://github.com/openstack/charm-nova-cloud-controller/blob/master/hooks/nova_cc_hooks.py#L1141 is being wrongly evaluated as 'None' (string) instead of None, therefore, the resource was being installed even if console-access-protocol has been set to None (as indicated by the configuration).

We have to fix this.

[Peter Sabaini (peter-sabaini)]

Some addtl. context, in case someone stumbles across this. The issue I ran across with the above was that the hacluster charm added the nova-consoleauth resource, but corosync was erroring out as the nova-consoleauth pkg wasn't getting installed, and corosync would miss the service binary.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/473915

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/473915
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=51b7a600c8aac9e7c90aba6deb40af245c38f281
Submitter: Jenkins
Branch: master

commit 51b7a600c8aac9e7c90aba6deb40af245c38f281
Author: Jorge Niedbalski <email address hidden>
Date: Tue Jun 13 13:06:22 2017 -0400

    Evaluate 'None' as None in console_attributes.

    The config.yaml file suggests None as one
    of the possible values of the directive console-access-protocol,
    this is wrongly evaluated as a string in the console_attributes
    function, which causes the charm to install the pacemaker
    resource even when is not required (console-access-protocol = None).

    Change-Id: I367b7fd813e044bc6eedca687e837e8adab2dd40
    Closes-Bug: #1697693
    Depends-On: I98ebbf9f2c7582fae5f466dfc1d224bf66e38a24
    Signed-off-by: Jorge Niedbalski <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/17.02
Review: https://review.openstack.org/476206

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/476206
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=daa71b3c7d2b06e323f5f50d0c0e1bf67e9fa1b9
Submitter: Jenkins
Branch: stable/17.02

commit daa71b3c7d2b06e323f5f50d0c0e1bf67e9fa1b9
Author: Jorge Niedbalski <email address hidden>
Date: Tue Jun 13 13:06:22 2017 -0400

    Evaluate 'None' as None in console_attributes.

    The config.yaml file suggests None as one
    of the possible values of the directive console-access-protocol,
    this is wrongly evaluated as a string in the console_attributes
    function, which causes the charm to install the pacemaker
    resource even when is not required (console-access-protocol = None).

    Change-Id: I367b7fd813e044bc6eedca687e837e8adab2dd40
    Closes-Bug: #1697693
    Depends-On: I98ebbf9f2c7582fae5f466dfc1d224bf66e38a24
    Signed-off-by: Jorge Niedbalski <email address hidden>
    (cherry picked from commit 51b7a600c8aac9e7c90aba6deb40af245c38f281)