hypervisor not registered on xena+

[Liam Young]

Cells hypervisors are not being registered when deploying xena (and probably later).

$ openstack compute service list --service nova-compute

$

This appears to be due to the charm not putting the database url in the correct place in config which causes the nova code to think its an api conductor.

The fix seems to remove the old sql_connection from the default section and add:

[database]
connection = mysql+pymysql://nova:dzMXxxHRXxzmBfY4YF7cYw8bz7pF5Sfc@127.0.0.1:3316/nova

[Liam Young (gnuoy)]

This is the upstream code https://opendev.org/openstack/nova/src/branch/master/nova/utils.py#L1060

Using sql_connection appears to populate CONF.api_database.connection behind the scenes

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-nova-cell-controller/+/850275

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-nova-cell-controller/+/850275
Committed: https://opendev.org/openstack/charm-nova-cell-controller/commit/d668de8aa5bba642015d817f3272df43a955a1ff
Submitter: "Zuul (22348)"
Branch: master

commit d668de8aa5bba642015d817f3272df43a955a1ff
Author: Liam Young <email address hidden>
Date: Tue Jul 19 06:30:46 2022 +0000

    Fix database connection section

    Using the sql_connection option in the default section appears to
    cause CONF.api_database.connection to be populated with the
    connection uri. This in turn causes nova to think this is an
    api cell and to do an api lookup *1 which fails. This change moves
    the database connection string into its own section as per *2

    *1 https://opendev.org/openstack/nova/src/branch/master/nova/utils.py#L1060
    *2 https://docs.openstack.org/nova/latest/admin/cells.html

    Closes-Bug: #1982071
    Change-Id: I49859235d408598535173c8bb87ce65f66fb3ca8

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-nova-cell-controller/+/850465

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-nova-cell-controller/+/850466

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-nova-cell-controller/+/850466
Committed: https://opendev.org/openstack/charm-nova-cell-controller/commit/c097dc38234e0972b7082a539730c004b6c86b13
Submitter: "Zuul (22348)"
Branch: stable/xena

commit c097dc38234e0972b7082a539730c004b6c86b13
Author: Liam Young <email address hidden>
Date: Tue Jul 19 06:30:46 2022 +0000

    Fix database connection section

    Using the sql_connection option in the default section appears to
    cause CONF.api_database.connection to be populated with the
    connection uri. This in turn causes nova to think this is an
    api cell and to do an api lookup *1 which fails. This change moves
    the database connection string into its own section as per *2

    *1 https://opendev.org/openstack/nova/src/branch/master/nova/utils.py#L1060
    *2 https://docs.openstack.org/nova/latest/admin/cells.html

    Closes-Bug: #1982071
    Change-Id: I49859235d408598535173c8bb87ce65f66fb3ca8
    (cherry picked from commit d668de8aa5bba642015d817f3272df43a955a1ff)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-nova-cell-controller/+/850465
Committed: https://opendev.org/openstack/charm-nova-cell-controller/commit/55a00b4a1356a3679bedf6c7d9b93496e8466b3e
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 55a00b4a1356a3679bedf6c7d9b93496e8466b3e
Author: Liam Young <email address hidden>
Date: Tue Jul 19 06:30:46 2022 +0000

    Fix database connection section

    Using the sql_connection option in the default section appears to
    cause CONF.api_database.connection to be populated with the
    connection uri. This in turn causes nova to think this is an
    api cell and to do an api lookup *1 which fails. This change moves
    the database connection string into its own section as per *2

    *1 https://opendev.org/openstack/nova/src/branch/master/nova/utils.py#L1060
    *2 https://docs.openstack.org/nova/latest/admin/cells.html

    Closes-Bug: #1982071
    Change-Id: I49859235d408598535173c8bb87ce65f66fb3ca8
    (cherry picked from commit d668de8aa5bba642015d817f3272df43a955a1ff)