OpenStack Neutron Open vSwitch Charm

hook/install is broken if "deb xxx" line is supplied

Bug #1980020 reported by Tilman Baumann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Neutron Open vSwitch Charm
Fix Committed
Undecided
Unassigned

Bug Description

apt-add-repository needs a quote around $NETWORKING_TOOLS_PPA in case the `networking-tools-source` config is a "deb http/...." line instead of a PPA name.

I will supply a patch in a second

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-openvswitch (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/847861

Changed in charm-neutron-openvswitch:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-neutron-openvswitch (master)

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/847861
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/b7a0f7a708478a6e74cc126d50c41fc0e9995228
Submitter: "Zuul (22348)"
Branch: master

commit b7a0f7a708478a6e74cc126d50c41fc0e9995228
Author: Tilman Baumann <email address hidden>
Date: Mon Jun 27 23:36:55 2022 +0100

    Quote single parameter string

    Quotes around paramerer string because apt-add-repository requires
    single parameter but networking-tools-source can contain multiple word entries.

    Closes-Bug: #1980020
    Change-Id: Ia59acbfb997e5df8638d8ad9135f11b121302815

Changed in charm-neutron-openvswitch:
status: In Progress → Fix Committed
Tilman Baumann (tilmanbaumann)
summary: - hook/install is broken if "deb xxx" line use supplied
+ hook/install is broken if "deb xxx" line is supplied
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.