Missing extensions=qos in sriov_agent.ini - Cannot use qos with sriov

[Marco Marino]

It seems that there is a missing "enable-qos" parameter for this charm. Indeed if I have enable-sriov=true and I want to use qos with sriov, I need a piece of configuration in /etc/neutron/plugins/ml2/sriov_agent.ini that actually is missing

The missing part is:

[agent]
extensions = qos

So, a possible solution could be:

in /etc/neutron/plugins/ml2/sriov_agent.ini:

{% if enable_sriov and enable_qos -%}
[agent]
extensions = qos
{% endif -%}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/813882

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/21.10
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/815993

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Erlon R. Cruz <email address hidden>" on branch: stable/21.10
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/815993

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/813882
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/2a6cba8e6f6c609676a713e496ffd6f44264525d
Submitter: "Zuul (22348)"
Branch: master

commit 2a6cba8e6f6c609676a713e496ffd6f44264525d
Author: Erlon R. Cruz <email address hidden>
Date: Tue Aug 3 15:17:52 2021 -0300

    Fix QoS selection for SRIOV environments

    When QoS is set in the neutron-api charm, the neutron-openvswitch
    charm needs to add 'extensions = qos' to the sriov_agent.ini
    file.

    Closes-bug: #1938277
    Change-Id: I44fbf5991d2606161b1bcbc064d4bc68a2fbbb5b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/841159

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/841159
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/561a44e9489913bd191b2854a496b25913fd045a
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 561a44e9489913bd191b2854a496b25913fd045a
Author: Erlon R. Cruz <email address hidden>
Date: Tue Aug 3 15:17:52 2021 -0300

    Fix QoS selection for SRIOV environments

    When QoS is set in the neutron-api charm, the neutron-openvswitch
    charm needs to add 'extensions = qos' to the sriov_agent.ini
    file.

    Closes-bug: #1938277
    Change-Id: I44fbf5991d2606161b1bcbc064d4bc68a2fbbb5b
    (cherry picked from commit 2a6cba8e6f6c609676a713e496ffd6f44264525d)

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Erlon R. Cruz <email address hidden>" on branch: stable/21.10
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/815993
Reason: THis is in the wrongr branch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/845635

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/845635
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/4a8f542f78b1a0e0070d7b90079c9235c2cbd103
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 4a8f542f78b1a0e0070d7b90079c9235c2cbd103
Author: Erlon R. Cruz <email address hidden>
Date: Tue Aug 3 15:17:52 2021 -0300

    Fix QoS selection for SRIOV environments

    When QoS is set in the neutron-api charm, the neutron-openvswitch
    charm needs to add 'extensions = qos' to the sriov_agent.ini
    file.

    Closes-bug: #1938277
    Change-Id: I44fbf5991d2606161b1bcbc064d4bc68a2fbbb5b
    (cherry picked from commit 2a6cba8e6f6c609676a713e496ffd6f44264525d)
    (cherry picked from commit 561a44e9489913bd191b2854a496b25913fd045a)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/850007

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/850009

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/850009
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/44e295e654fce03a2c3014855b41f66f4b6ef5fb
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 44e295e654fce03a2c3014855b41f66f4b6ef5fb
Author: Erlon R. Cruz <email address hidden>
Date: Tue Aug 3 15:17:52 2021 -0300

    Fix QoS selection for SRIOV environments

    When QoS is set in the neutron-api charm, the neutron-openvswitch
    charm needs to add 'extensions = qos' to the sriov_agent.ini
    file.

    Closes-bug: #1938277
    Change-Id: I44fbf5991d2606161b1bcbc064d4bc68a2fbbb5b
    (cherry picked from commit 2a6cba8e6f6c609676a713e496ffd6f44264525d)
    (cherry picked from commit 561a44e9489913bd191b2854a496b25913fd045a)
    (cherry picked from commit 4a8f542f78b1a0e0070d7b90079c9235c2cbd103)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/850007
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/c240757e669ae108906aa06088664b61a319b551
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit c240757e669ae108906aa06088664b61a319b551
Author: Erlon R. Cruz <email address hidden>
Date: Tue Aug 3 15:17:52 2021 -0300

    Fix QoS selection for SRIOV environments

    When QoS is set in the neutron-api charm, the neutron-openvswitch
    charm needs to add 'extensions = qos' to the sriov_agent.ini
    file.

    Closes-bug: #1938277
    Change-Id: I44fbf5991d2606161b1bcbc064d4bc68a2fbbb5b
    (cherry picked from commit 2a6cba8e6f6c609676a713e496ffd6f44264525d)
    (cherry picked from commit 561a44e9489913bd191b2854a496b25913fd045a)
    (cherry picked from commit 4a8f542f78b1a0e0070d7b90079c9235c2cbd103)
    (cherry picked from commit 246128d98e39508b491593aca4ff4d1f8dfe2151)