disable neutron-fwaas for >= victoria

Bug #1934129 reported by Edward Hope-Morley
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Charm Helpers
Fix Released
Undecided
Hemanth Nakkina
OpenStack Charm Guide
Fix Released
Medium
Peter Matulis
OpenStack Dashboard Charm
Fix Released
Undecided
Hemanth Nakkina
OpenStack Neutron API Charm
Fix Released
High
Edward Hope-Morley
OpenStack Neutron Gateway Charm
Fix Released
Undecided
Hemanth Nakkina
OpenStack Neutron Open vSwitch Charm
Fix Released
Undecided
Hemanth Nakkina
Ubuntu Cloud Archive
Fix Released
High
Unassigned
Victoria
Fix Released
High
Unassigned
Wallaby
Fix Released
High
Unassigned
Xena
Fix Released
High
Unassigned
neutron (Ubuntu)
Fix Released
High
Unassigned
Hirsute
Fix Released
High
Unassigned
Impish
Fix Released
High
Unassigned

Bug Description

[Description]
The neutron-fwaas project is retired and there are no updates beyond 16.0.0. The neutron-api charm still enables it by default, and the package still installs it as a dependency, and it is currently broken so we should remove it from >= V and add an optional to disable it for earlier releases.

[Test Case]
The following SRU process was followed:
https://wiki.ubuntu.com/OpenStack/StableReleaseUpdates

In order to avoid regression of existing consumers, the OpenStack team will run their continuous integration test against the packages that are in -proposed. A successful run of all available tests will be required before the proposed packages can be let into -updates.

The OpenStack team will be in charge of attaching the output summary of the executed tests. The OpenStack team members will not mark ‘verification-done’ until this has happened.

[Regression Potential]
In order to mitigate the regression potential, the results of the
aforementioned tests are attached to this bug.

[Discussion]
For new deploys, binary package installs of neutron-l3-agent will no longer install the python3-neutron-fwaas dependency. The fwaas plugin isn't enabled by default. If a user wants to enable the fwaas plugin, they will still be able to, they will just need to manually install the python3-neutron-fwaas package

Existing deployments that upgrade to the new package will continue to have python3-neutron-fwaas installed on the system, and therefore if they had the fwaas plugin enabled, it will still be enabled and the fwaas package will still be installed. Apt, however, will list the fwaas packages as being no longer required.

Changed in charm-neutron-api:
milestone: none → 21.10
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-api (master)
Changed in charm-neutron-api:
status: New → In Progress
Changed in charm-neutron-api:
assignee: nobody → Edward Hope-Morley (hopem)
Revision history for this message
Aurelien Lourot (aurelien-lourot) wrote :

Adding 'charm-guide' as affected project for the 21.10 release notes, thanks!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-neutron-api (master)

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-api/+/798934
Committed: https://opendev.org/openstack/charm-neutron-api/commit/00e7c8b6ad32108cf0d6f317e281c6090a588240
Submitter: "Zuul (22348)"
Branch: master

commit 00e7c8b6ad32108cf0d6f317e281c6090a588240
Author: Edward Hope-Morley <email address hidden>
Date: Wed Jun 30 17:57:53 2021 +0100

    Remove neutron-fwaas for >= V

    Also adds config option enable-fwaas which defaults to
    True to allow disabling fwaas for releases earlier than
    Victoria.

    Change-Id: Ic9251c5290f777f544a150a92702566474b264b8
    Closes-Bug: 1934129

Changed in charm-neutron-api:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-guide (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-guide/+/799834

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-api (stable/21.04)

Fix proposed to branch: stable/21.04
Review: https://review.opendev.org/c/openstack/charm-neutron-api/+/799842

Changed in charm-guide:
status: New → In Progress
assignee: nobody → Aurelien Lourot (aurelien-lourot)
Changed in charm-guide:
assignee: Aurelien Lourot (aurelien-lourot) → Peter Matulis (petermatulis)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-guide (master)

Reviewed: https://review.opendev.org/c/openstack/charm-guide/+/799834
Committed: https://opendev.org/openstack/charm-guide/commit/f4824587b12ac595436ae08968b5c91ee4f27cd1
Submitter: "Zuul (22348)"
Branch: master

commit f4824587b12ac595436ae08968b5c91ee4f27cd1
Author: Edward Hope-Morley <email address hidden>
Date: Wed Jul 7 14:52:40 2021 +0100

    Add 21.10 neutron-api charm release note

    fwaas removal and config option

    Related-Bug: 1934129
    Change-Id: I85be5d7897b4c32aefa98daf376c53f4332a9615

Changed in charm-guide:
milestone: none → 21.10
status: In Progress → Fix Committed
Changed in charm-neutron-api:
milestone: 21.10 → 21.04
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-neutron-api (stable/21.04)

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-api/+/799842
Committed: https://opendev.org/openstack/charm-neutron-api/commit/98722d0a838d08b09c03ff0a068400a0710223af
Submitter: "Zuul (22348)"
Branch: stable/21.04

commit 98722d0a838d08b09c03ff0a068400a0710223af
Author: Edward Hope-Morley <email address hidden>
Date: Wed Jun 30 17:57:53 2021 +0100

    Remove neutron-fwaas for >= V

    Also adds config option enable-fwaas which defaults to
    True to allow disabling fwaas for releases earlier than
    Victoria.

    Change-Id: Ic9251c5290f777f544a150a92702566474b264b8
    Closes-Bug: 1934129
    (cherry picked from commit 00e7c8b6ad32108cf0d6f317e281c6090a588240)

Revision history for this message
Edward Hope-Morley (hopem) wrote :

I've just discovered that the patch above has a critical issue in that if you set enable-fwaas=false for < V it will correctly remove the package but not remove firewall service plugin. Since neutron-server does not get restarted the error only occurs one neutron-server gets restarted. So the issue is this remains:

# grep -r service_plugins /etc/neutron/
/etc/neutron/neutron.conf:service_plugins = router,firewall_v2,metering,segments,neutron_dynamic_routing.services.bgp.bgp_plugin.BgpPlugin

i.e. "firewall_v2"

I will prepare a patch now to fix this.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-api (master)
Revision history for this message
Edward Hope-Morley (hopem) wrote :

n-g and n-ovs independently enable fwaas extension so we need to apply this to those charms as well.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-api (stable/21.04)

Fix proposed to branch: stable/21.04
Review: https://review.opendev.org/c/openstack/charm-neutron-api/+/801619

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-neutron-api (master)

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-api/+/801513
Committed: https://opendev.org/openstack/charm-neutron-api/commit/2e0896c737eb09d6e8a89da02f5e4043d81c9c48
Submitter: "Zuul (22348)"
Branch: master

commit 2e0896c737eb09d6e8a89da02f5e4043d81c9c48
Author: Edward Hope-Morley <email address hidden>
Date: Tue Jul 20 17:16:34 2021 +0100

    Fixes disabling fwaas

    Commit 00e7c8b added support for disabling fwaas but
    forgot to remove the firewall plugin from service_plugins
    once the fwaas package has been removed. This patch fixes
    that.

    Change-Id: I75fdd192144138fa5bf09c278d5507ca8c5366d1
    Closes-Bug: #1934129

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-neutron-api (stable/21.04)

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-api/+/801619
Committed: https://opendev.org/openstack/charm-neutron-api/commit/ea7e7dd2c66c73a470f39b0fab1d1e33878dec25
Submitter: "Zuul (22348)"
Branch: stable/21.04

commit ea7e7dd2c66c73a470f39b0fab1d1e33878dec25
Author: Edward Hope-Morley <email address hidden>
Date: Tue Jul 20 17:16:34 2021 +0100

    Fixes disabling fwaas

    Commit 00e7c8b added support for disabling fwaas but
    forgot to remove the firewall plugin from service_plugins
    once the fwaas package has been removed. This patch fixes
    that.

    Change-Id: I75fdd192144138fa5bf09c278d5507ca8c5366d1
    Closes-Bug: #1934129
    (cherry picked from commit a144a583196ef6b655a7ad60eaab2f8f97a6a5ee)

Revision history for this message
Brett Milford (brettmilford) wrote :

Adding openstack-dashboard charm as it installs python3-neutron-fwaas-dashboard dashboard plugin.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-api (master)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-openvswitch (master)
Changed in charm-neutron-openvswitch:
status: New → In Progress
Revision history for this message
Hemanth Nakkina (hemanth-n) wrote (last edit ):

Following patches submitted to
* enable/disable fwaas extension on neutron-l3-agent based on neutron-api charm configuration option enable-fwaas
* remove python3-neutron-fwaas package from victoria onwards

https://github.com/juju/charm-helpers/pull/635
https://review.opendev.org/c/openstack/charm-neutron-api/+/806676
https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/806677
https://review.opendev.org/c/openstack/charm-neutron-gateway/+/806834

Changed in charm-neutron-openvswitch:
assignee: nobody → Hemanth Nakkina (hemanth-n)
Changed in charm-helpers:
status: New → In Progress
assignee: nobody → Hemanth Nakkina (hemanth-n)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-gateway (master)
Changed in charm-neutron-gateway:
status: New → In Progress
Changed in charm-neutron-gateway:
assignee: nobody → Hemanth Nakkina (hemanth-n)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-neutron-api (master)

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-api/+/806676
Committed: https://opendev.org/openstack/charm-neutron-api/commit/69af89a6158679e87d9b6c2a437268b725fbcd80
Submitter: "Zuul (22348)"
Branch: master

commit 69af89a6158679e87d9b6c2a437268b725fbcd80
Author: Hemanth Nakkina <email address hidden>
Date: Tue Aug 31 11:07:12 2021 +0530

    Add enable-fwaas to relation data

    Add enable-fwaas to neutron-plugin-api relation data so
    that neutron-openvswitch updates neutron-l3-agent
    configuration accordingly.

    Synced charmhelpers to get related changes
    https://github.com/juju/charm-helpers/pull/635

    Partial-Bug: #1934129
    Change-Id: I5019c5ed3b8ab556d4900f1fe46dee69f5f09ee7

Revision history for this message
Edward Hope-Morley (hopem) wrote :

The neutron package still defines fwaas as a dependency of neutron-l3-agent which is blocking it from being removed by the charm. We need to fix that so I will add the package to this bug too.

https://git.launchpad.net/~ubuntu-openstack-dev/ubuntu/+source/neutron/tree/debian/control#n152

Changed in neutron (Ubuntu Hirsute):
status: New → Triaged
Changed in neutron (Ubuntu Impish):
status: New → Triaged
importance: Undecided → High
Changed in neutron (Ubuntu Hirsute):
importance: Undecided → High
description: updated
Revision history for this message
Corey Bryant (corey.bryant) wrote :

This is now fixed in all corresponing branches (victoria+) in package repository [1] and will be included with the next point release uploads [2].

[1] https://code.launchpad.net/~ubuntu-openstack-dev/ubuntu/+source/neutron/+git/neutron
[2] https://review.opendev.org/c/openstack/releases/+/808012

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package neutron - 2:18.1.0+git2021090913.64bfeae21c-0ubuntu1

---------------
neutron (2:18.1.0+git2021090913.64bfeae21c-0ubuntu1) impish; urgency=medium

  * New upstream snapshot for OpenStack Xena.
  * d/control: Align (Build-)Depends with upstream.
  * d/control: Drop neutron-fwaas dependency as it is no longer maintained
    (LP: #1934129).
  * d/p/revert-rely-on-worker-count-for-hashring-caching.patch: Dropped.
    Fixed upstream by https://review.opendev.org/c/openstack/neutron/+/800679.
  * d/p/revert-sqlalchemy-upgrade.patch: Rebased.
  * d/p/revert-l3-ha-retry-when-setting-ha-router-gw-status.patch: Dropped.
    Fixed in new upstream snapshot.

 -- Corey Bryant <email address hidden> Thu, 09 Sep 2021 13:01:27 -0400

Changed in neutron (Ubuntu Impish):
status: Triaged → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-neutron-gateway (master)

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-gateway/+/806834
Committed: https://opendev.org/openstack/charm-neutron-gateway/commit/de22d6cbe2d9755048019674b8be1a4d11280649
Submitter: "Zuul (22348)"
Branch: master

commit de22d6cbe2d9755048019674b8be1a4d11280649
Author: Hemanth Nakkina <email address hidden>
Date: Wed Sep 1 11:16:01 2021 +0530

    Add extension fwaas_v2 based on neutron-api relation data

    fwaas_v2 extension is added in l3_agent.ini by default from stein.
    However with the newly introduced neutron-api configuration parameter
    enable-fwaas, the extension have to added only when it is set to true
    on neutron-api charm.

    neutron-api charm adds enabled-fwaas as relation data in the commit
    https://review.opendev.org/c/openstack/charm-neutron-api/+/806676.
    This patch removes special handling of fwaas_v2 as l3_extension_plugins
    is already updated in relation data based on neutron-api enable-fwaas
    configuration.

    Remove python3-neutron-fwaas in package list from stein release. The
    package is already part of dependency of neutron-l3-agent until Ussuri
    release and the dependency will be removed from Victoria release in
    package control files.

    Synced charmhelpers to get related changes
    https://github.com/juju/charm-helpers/pull/635

    Partial-Bug: #1934129
    Change-Id: I07db7fb7c2f00eaf4c0a5bcc082c73922b87d1c0

Changed in charm-neutron-openvswitch:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-neutron-openvswitch (master)

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/806677
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/d3daa09bc49bcc5c66791565e1720a9a484ea149
Submitter: "Zuul (22348)"
Branch: master

commit d3daa09bc49bcc5c66791565e1720a9a484ea149
Author: Hemanth Nakkina <email address hidden>
Date: Tue Aug 31 11:14:43 2021 +0530

    Add extension fwaas_v2 based on neutron-api relation data

    fwaas_v2 extension is added in l3_agent.ini by default from stein.
    However with the newly introduced neutron-api configuration parameter
    enable-fwaas, the extension have to added only when it is set to true
    on neutron-api charm.

    neutron-api charm adds enabled-fwaas as relation data in the commit
    https://review.opendev.org/c/openstack/charm-neutron-api/+/806676.
    This patch removes special handling of fwaas_v2 as l3_extension_plugins
    is already updated in relation data based on neutron-api enable-fwaas
    configuration.

    Add python3-neutron-fwaas in py3 package list only for rocky release. The
    package is already part of dependency of neutron-l3-agent until Ussuri
    release and the dependency will be removed from Victoria release in
    package control files.

    Synced charmhelpers to get related changes
    https://github.com/juju/charm-helpers/pull/635

    Closes-Bug: #1934129
    Change-Id: I1546f45635bfd7af76001c1df4f99d219a9d8039

Changed in cloud-archive:
status: Triaged → Fix Committed
Revision history for this message
Corey Bryant (corey.bryant) wrote :

This bug was fixed in the package neutron - 2:18.1.0+git2021090913.64bfeae21c-0ubuntu1~cloud0
---------------

 neutron (2:18.1.0+git2021090913.64bfeae21c-0ubuntu1~cloud0) focal-xena; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 neutron (2:18.1.0+git2021090913.64bfeae21c-0ubuntu1) impish; urgency=medium
 .
   * New upstream snapshot for OpenStack Xena.
   * d/control: Align (Build-)Depends with upstream.
   * d/control: Drop neutron-fwaas dependency as it is no longer maintained
     (LP: #1934129).
   * d/p/revert-rely-on-worker-count-for-hashring-caching.patch: Dropped.
     Fixed upstream by https://review.opendev.org/c/openstack/neutron/+/800679.
   * d/p/revert-sqlalchemy-upgrade.patch: Rebased.
   * d/p/revert-l3-ha-retry-when-setting-ha-router-gw-status.patch: Dropped.
     Fixed in new upstream snapshot.

Changed in cloud-archive:
status: Fix Committed → Fix Released
Changed in charm-helpers:
status: In Progress → Fix Committed
Changed in charm-neutron-gateway:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-api (stable/21.04)

Fix proposed to branch: stable/21.04
Review: https://review.opendev.org/c/openstack/charm-neutron-api/+/808928

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/21.04
Review: https://review.opendev.org/c/openstack/charm-neutron-api/+/808929

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-neutron-api (stable/21.04)

Change abandoned by "Hemanth N <email address hidden>" on branch: stable/21.04
Review: https://review.opendev.org/c/openstack/charm-neutron-api/+/808928

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-openvswitch (stable/21.04)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-gateway (stable/21.04)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-openvswitch (stable/21.04)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-neutron-openvswitch (stable/21.04)

Change abandoned by "Hemanth N <email address hidden>" on branch: stable/21.04
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/808930

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by "Hemanth N <email address hidden>" on branch: stable/21.04
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/808935
Reason: Cherrypick not done properly

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-neutron-gateway (stable/21.04)

Change abandoned by "Hemanth N <email address hidden>" on branch: stable/21.04
Review: https://review.opendev.org/c/openstack/charm-neutron-gateway/+/808934
Reason: Cherrypick not done properly

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-openvswitch (stable/21.04)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-neutron-gateway (stable/21.04)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-neutron-api (stable/21.04)

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-api/+/808929
Committed: https://opendev.org/openstack/charm-neutron-api/commit/33de9d5f3bc958178a2f57f9c29e38394d9c0ed1
Submitter: "Zuul (22348)"
Branch: stable/21.04

commit 33de9d5f3bc958178a2f57f9c29e38394d9c0ed1
Author: Hemanth Nakkina <email address hidden>
Date: Tue Sep 14 16:39:46 2021 +0530

    Add enable-fwaas to relation data

    Add enable-fwaas to neutron-plugin-api relation data so
    that neutron-openvswitch updates neutron-l3-agent
    configuration accordingly.

    Synced charmhelpers to get related changes
    https://github.com/juju/charm-helpers/pull/640

    Partial-Bug: #1934129

    (cherry picked from commit 69af89a6158679e87d9b6c2a437268b725fbcd80)
    Change-Id: I5019c5ed3b8ab556d4900f1fe46dee69f5f09ee7

Revision history for this message
Steve Langasek (vorlon) wrote :

The upload in the SRU queue for hirsute shows only that the dependency on the python3-neutron-fwaas package has been dropped. There are no other references to fwaas in the package delta. Please explain as part of this SRU how, at the package level (rather than the charm level), this upgrade affects users who previously had fwaas enabled in their configs.

Changed in neutron (Ubuntu Hirsute):
status: Triaged → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-neutron-openvswitch (stable/21.04)

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/808937
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/efac9bd199eb0a03abfd247f363797a46ade45b1
Submitter: "Zuul (22348)"
Branch: stable/21.04

commit efac9bd199eb0a03abfd247f363797a46ade45b1
Author: Hemanth Nakkina <email address hidden>
Date: Tue Aug 31 11:14:43 2021 +0530

    Add extension fwaas_v2 based on neutron-api relation data

    fwaas_v2 extension is added in l3_agent.ini by default from stein.
    However with the newly introduced neutron-api configuration parameter
    enable-fwaas, the extension have to added only when it is set to true
    on neutron-api charm.

    neutron-api charm adds enabled-fwaas as relation data in the commit
    https://review.opendev.org/c/openstack/charm-neutron-api/+/806676.
    This patch removes special handling of fwaas_v2 as l3_extension_plugins
    is already updated in relation data based on neutron-api enable-fwaas
    configuration.

    Add python3-neutron-fwaas in py3 package list only for rocky release. The
    package is already part of dependency of neutron-l3-agent until Ussuri
    release and the dependency will be removed from Victoria release in
    package control files.

    Synced charmhelpers to get related changes
    https://github.com/juju/charm-helpers/pull/640

    Closes-Bug: #1934129
    Change-Id: I1546f45635bfd7af76001c1df4f99d219a9d8039
    (cherry picked from commit d3daa09bc49bcc5c66791565e1720a9a484ea149)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-neutron-gateway (stable/21.04)

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-gateway/+/808938
Committed: https://opendev.org/openstack/charm-neutron-gateway/commit/011ee19f85296ef5462f0db3ec1483f34be94c39
Submitter: "Zuul (22348)"
Branch: stable/21.04

commit 011ee19f85296ef5462f0db3ec1483f34be94c39
Author: Hemanth Nakkina <email address hidden>
Date: Wed Sep 1 11:16:01 2021 +0530

    Add extension fwaas_v2 based on neutron-api relation data

    fwaas_v2 extension is added in l3_agent.ini by default from stein.
    However with the newly introduced neutron-api configuration parameter
    enable-fwaas, the extension have to added only when it is set to true
    on neutron-api charm.

    neutron-api charm adds enabled-fwaas as relation data in the commit
    https://review.opendev.org/c/openstack/charm-neutron-api/+/806676.
    This patch removes special handling of fwaas_v2 as l3_extension_plugins
    is already updated in relation data based on neutron-api enable-fwaas
    configuration.

    Remove python3-neutron-fwaas in package list from stein release. The
    package is already part of dependency of neutron-l3-agent until Ussuri
    release and the dependency will be removed from Victoria release in
    package control files.

    Synced charmhelpers to get related changes
    https://github.com/juju/charm-helpers/pull/640

    Partial-Bug: #1934129
    Change-Id: I07db7fb7c2f00eaf4c0a5bcc082c73922b87d1c0
    (cherry picked from commit de22d6cbe2d9755048019674b8be1a4d11280649)

Changed in charm-neutron-gateway:
milestone: none → 21.04
status: Fix Committed → Fix Released
Changed in charm-neutron-openvswitch:
milestone: none → 21.04
status: Fix Committed → Fix Released
Revision history for this message
Corey Bryant (corey.bryant) wrote : Re: [Bug 1934129] Re: disable neutron-fwaas for >= victoria

On Fri, Sep 17, 2021 at 1:25 PM Steve Langasek <email address hidden>
wrote:

> The upload in the SRU queue for hirsute shows only that the dependency
> on the python3-neutron-fwaas package has been dropped. There are no
> other references to fwaas in the package delta. Please explain as part
> of this SRU how, at the package level (rather than the charm level),
> this upgrade affects users who previously had fwaas enabled in their
> configs.
>
>
Thanks for the comment Steve. I've added some details to the SRU
[Discussion] section regarding expected behavior for new and existing
installs.

Thanks,
Corey

description: updated
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Edward, or anyone else affected,

Accepted neutron into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/neutron/2:18.1.1-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in neutron (Ubuntu Hirsute):
status: Incomplete → Fix Committed
tags: added: verification-needed verification-needed-hirsute
Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

Hello Edward, or anyone else affected,

Accepted neutron into victoria-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:victoria-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-victoria-needed to verification-victoria-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-victoria-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-victoria-needed
Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

Hello Edward, or anyone else affected,

Accepted neutron into wallaby-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:wallaby-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-wallaby-needed to verification-wallaby-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-wallaby-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-wallaby-needed
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Deployed hirsute-wallaby with -proposed and looks good to me:

$ juju run -a neutron-gateway -- dpkg -l| grep fwaas
$ juju run -a neutron-openvswitch -- dpkg -l| grep fwaas
$ juju run -a neutron-api -- dpkg -l| grep neutron-common
ii neutron-common 2:18.1.1-0ubuntu2 all Neutron is a virtual network service for Openstack - common
$ openstack extension list 2>&1| egrep "fwaas|fire"
$

Created a vm and can ping it's fip.

tags: added: verification-done-hirsute
removed: verification-needed-hirsute
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package neutron - 2:18.1.1-0ubuntu2

---------------
neutron (2:18.1.1-0ubuntu2) hirsute; urgency=medium

  * d/p/lp1934912-set-arp-entries-only-for-single-ip.patch: Cherry-pick
    upstream patch (LP: #1934912)

neutron (2:18.1.1-0ubuntu1) hirsute; urgency=medium

  [ Corey Bryant ]
  * d/control: Drop neutron-fwaas dependency as it is no longer maintained
    (LP: #1934129).
  * d/p/revert-rely-on-worker-count-for-hashring-caching.patch: Dropped.
    Fixed upstream by https://review.opendev.org/c/openstack/neutron/+/800679
    in the 18.1.1 stable release.

  [ Chris MacNaughton ]
  * New stable point release for OpenStack Wallaby (LP: #1943709).
  * d/p/series: Remove reference to removed patch.

 -- Chris MacNaughton <email address hidden> Fri, 01 Oct 2021 06:42:37 +0000

Changed in neutron (Ubuntu Hirsute):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for neutron has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Deployed bionic-wallaby with -proposed and looks good to me:

$ juju run -a neutron-gateway -- dpkg -l| grep fwaas
$ juju run -a neutron-openvswitch -- dpkg -l| grep fwaas
$ juju run -a neutron-api -- dpkg -l| grep neutron-common
ii neutron-common 2:18.1.1-0ubuntu2~cloud0 all Neutron is a virtual network service for Openstack - common
$ openstack extension list 2>&1| egrep "fwaas|fire"
$

Created a vm and can ping it's fip.

tags: added: verification-wallaby-done
removed: verification-wallaby-needed
Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

The verification of the Stable Release Update for neutron has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

This bug was fixed in the package neutron - 2:18.1.1-0ubuntu2~cloud0
---------------

 neutron (2:18.1.1-0ubuntu2~cloud0) focal-wallaby; urgency=medium
 .
   * New upstream release for the Ubuntu Cloud Archive.
 .
 neutron (2:18.1.1-0ubuntu2) hirsute; urgency=medium
 .
   * d/p/lp1934912-set-arp-entries-only-for-single-ip.patch: Cherry-pick
     upstream patch (LP: #1934912)
 .
 neutron (2:18.1.1-0ubuntu1) hirsute; urgency=medium
 .
   [ Corey Bryant ]
   * d/control: Drop neutron-fwaas dependency as it is no longer maintained
     (LP: #1934129).
   * d/p/revert-rely-on-worker-count-for-hashring-caching.patch: Dropped.
     Fixed upstream by https://review.opendev.org/c/openstack/neutron/+/800679
     in the 18.1.1 stable release.
 .
   [ Chris MacNaughton ]
   * New stable point release for OpenStack Wallaby (LP: #1943709).
   * d/p/series: Remove reference to removed patch.

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Deployed bionic-victoria with -proposed and looks good to me:

$ juju run -a neutron-api -- dpkg -l| grep fwaas
$ juju run -a neutron-gateway -- dpkg -l| grep fwaas
$ juju run -a neutron-openvswitch -- dpkg -l| grep fwaas
$ juju run -a neutron-api -- dpkg -l| grep neutron-common
ii neutron-common 2:17.2.1-0ubuntu1~cloud2 all Neutron is a virtual network service for Openstack - common
$ openstack extension list 2>&1| egrep "fwaas|fire"
$

Created a vm and can ping it's fip.

tags: added: verification-done verification-victoria-done
removed: verification-needed verification-victoria-needed
Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

The verification of the Stable Release Update for neutron has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

This bug was fixed in the package neutron - 2:17.2.1-0ubuntu1~cloud2
---------------

 neutron (2:17.2.1-0ubuntu1~cloud2) ifocal-victoria; urgency=medium
 .
   * No change rebuild
 .
 neutron (2:17.2.1-0ubuntu1~cloud1) focal-victoria; urgency=medium
 .
   * d/p/lp1934912-set-arp-entries-only-for-single-ip.patch: Cherry-pick
     upstream patch (LP: #1934912)
 .
 neutron (2:17.2.1-0ubuntu1~cloud0) focal-victoria; urgency=medium
 .
   [ Corey Bryant ]
   * d/control: Drop neutron-fwaas dependency as it is no longer maintained
     (LP: #1934129).
 .
   [ Chris MacNaughton ]
   * New stable point release for OpenStack Victoria (LP: #1943711).

Changed in charm-guide:
status: Fix Committed → Fix Released
Changed in charm-helpers:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-openstack-dashboard (master)
Changed in charm-openstack-dashboard:
status: New → In Progress
Changed in charm-openstack-dashboard:
assignee: nobody → Hemanth Nakkina (hemanth-n)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-openstack-dashboard (master)

Reviewed: https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/819756
Committed: https://opendev.org/openstack/charm-openstack-dashboard/commit/4355ea2d6b1cc47dc530c2dc83c0d87db7881bed
Submitter: "Zuul (22348)"
Branch: master

commit 4355ea2d6b1cc47dc530c2dc83c0d87db7881bed
Author: Hemanth Nakkina <email address hidden>
Date: Tue Nov 30 12:41:54 2021 +0530

    Remove neutron-fwaas-dashboard package for >= V

    neutron-fwaas project is retired from Victoria release.
    This patch removes installing neutron-fwaas-dashboard package
    from Victoria release onwards.

    Closes-Bug: 1934129
    Change-Id: Id2c8695274bb3438612ee44bb922766a6bddf900

Changed in charm-openstack-dashboard:
status: In Progress → Fix Committed
Changed in charm-openstack-dashboard:
milestone: none → 22.04
Changed in charm-openstack-dashboard:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.