After charm upgrade, adding networking-tools PPA fails due to add-apt-repo not using proxy
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Neutron Open vSwitch Charm |
Fix Released
|
High
|
Corey Bryant |
Bug Description
Scenario
========
Upgrade of neutron-openvswitch charm to the latest revision 282 (at the time at least) with the new enable-
Problem
=======
The run-deferred-hooks action hung for ~10 mins and finally failed. From the logs:
2021-05-17 20:51:44 DEBUG restart-services Cannot add PPA: 'ppa:~openstack
2021-05-17 20:51:44 DEBUG restart-services ERROR: '~openstack-
2021-05-17 20:51:44 DEBUG jujuc server.go:211 running hook tool "juju-log"
2021-05-17 20:51:44 INFO juju-log Failed executing 'add-apt-repository --yes ppa:openstack-
I found there was a recent commit that removed the passing of proxy settings to the "add-apt-
Workaround
==========
Manually hacked the charmhelpers code for the unit to include passing proxy vars to the command. This was taken from the new commit.
Obviously, this bug will be fixed on a new release of charmhelpers library. This bug helps with posterity of the issue. I'd imagine this is not the only openstack charm affected by this issue, but it's the only one I've hit it on yet.
[0] https:/
Link to in flight reviews - https:/ /review. opendev. org/c/openstack /charm- neutron- openvswitch/ +/791167