On wallaby openvswitch is restarted even though enable-auto-restarts=False

[Liam Young]

When running `dpkg-reconfigure openvswitch-switch` openvswitch services are restarted even though they should be blocked from restarting because enable-auto-restarts=False

This is because the charm does not put a policy file in place to block restarts of ovs-record-hostname.

[Felipe Reyes (freyes)]

2022-02-08 15:00:27.010539 | focal-medium | 2022-02-08 15:00:27 [ERROR] Service openvswitch-switch on unit neutron-openvswitch/0 should have start time of 2022-02-08 14:14:37 but it has 2022-02-08 14:59:11
2022-02-08 15:00:27.010915 | focal-medium | 2022-02-08 15:00:27 [ERROR] Service openvswitch-switch on unit neutron-openvswitch/1 should have start time of 2022-02-08 14:19:29 but it has 2022-02-08 14:59:35

neutron-openvswitch_0 $ cat var/log/policy-rc.d.log
[...]
2022-02-08 14:59:11,273 Permitting ovs-record-hostname.service restart
2022-02-08 14:59:12,329 restart of openvswitch-switch blocked by charm neutron-openvswitch

Occurrence seen in neutron-openvswitch gate - https://openstack-ci-reports.ubuntu.com/artifacts/e58/826707/3/check/migrate-ovn-focal-xena-dvr-snat/e5829b9/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/828422

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/828422
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/f6a9487b05b08e5481d0792d825c98548621e5c0
Submitter: "Zuul (22348)"
Branch: master

commit f6a9487b05b08e5481d0792d825c98548621e5c0
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 8 16:50:42 2022 -0300

    Mark ovs-record-hostname as deferable service.

    Add ovs-record-hostname to the list of deferrable services, this service
    was SRU'ed into Ubuntu >= Focal, when it's not mark as deferrable on
    package upgrades will induce a restart of openvswitch-switch.

    Change-Id: I4fa3256b39e62e9df223ab40f17f1677a621f293
    Closes-Bug: #1923636
    Related-Bug: #1915829

[Drew Freiberger (afreiberger)]

this bug appears to be patched since 21.04 for charm-ovn-chassis based on this charm-layer-ovn commit.

https://github.com/openstack-charmers/charm-layer-ovn/commit/3763cefeb2251ac6c736c456f4ae5f7b534033d5

[Hemanth Nakkina (hemanth-n)]

Just a note, the openvswitch restart is also observed during upgrade from bionic-train to bionic-ussuri. And the fix need to be backported until stable/ussuri.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/838224

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/838225

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/838226

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/838227

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/838224
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/1d4f077e1117c2f0ea8a21ef60333470c5077eeb
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 1d4f077e1117c2f0ea8a21ef60333470c5077eeb
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 8 16:50:42 2022 -0300

    Mark ovs-record-hostname as deferable service.

    Add ovs-record-hostname to the list of deferrable services, this service
    was SRU'ed into Ubuntu >= Focal, when it's not mark as deferrable on
    package upgrades will induce a restart of openvswitch-switch.

    Change-Id: I4fa3256b39e62e9df223ab40f17f1677a621f293
    Closes-Bug: #1923636
    Related-Bug: #1915829
    (cherry picked from commit f6a9487b05b08e5481d0792d825c98548621e5c0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/838225
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/96fb6408203b7d2c8592e6dd510fb7086160696a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 96fb6408203b7d2c8592e6dd510fb7086160696a
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 8 16:50:42 2022 -0300

    Mark ovs-record-hostname as deferable service.

    Add ovs-record-hostname to the list of deferrable services, this service
    was SRU'ed into Ubuntu >= Focal, when it's not mark as deferrable on
    package upgrades will induce a restart of openvswitch-switch.

    Change-Id: I4fa3256b39e62e9df223ab40f17f1677a621f293
    Closes-Bug: #1923636
    Related-Bug: #1915829
    (cherry picked from commit f6a9487b05b08e5481d0792d825c98548621e5c0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/838226
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/e3e8c74d99623ceb68558a387283cf0d19c45c58
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit e3e8c74d99623ceb68558a387283cf0d19c45c58
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 8 16:50:42 2022 -0300

    Mark ovs-record-hostname as deferable service.

    Add ovs-record-hostname to the list of deferrable services, this service
    was SRU'ed into Ubuntu >= Focal, when it's not mark as deferrable on
    package upgrades will induce a restart of openvswitch-switch.

    Change-Id: I4fa3256b39e62e9df223ab40f17f1677a621f293
    Closes-Bug: #1923636
    Related-Bug: #1915829
    (cherry picked from commit f6a9487b05b08e5481d0792d825c98548621e5c0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/838227
Committed: https://opendev.org/openstack/charm-neutron-openvswitch/commit/65f405d63296215cf4c923a43895e8b060a85225
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 65f405d63296215cf4c923a43895e8b060a85225
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 8 16:50:42 2022 -0300

    Mark ovs-record-hostname as deferable service.

    Add ovs-record-hostname to the list of deferrable services, this service
    was SRU'ed into Ubuntu >= Focal, when it's not mark as deferrable on
    package upgrades will induce a restart of openvswitch-switch.

    Change-Id: I4fa3256b39e62e9df223ab40f17f1677a621f293
    Closes-Bug: #1923636
    Related-Bug: #1915829
    (cherry picked from commit f6a9487b05b08e5481d0792d825c98548621e5c0)