OVS bridges and ports are not marked as managed by the charm

[Przemyslaw Lal]

There's an inconsistent behaviour between neutron-openvswtich and neutron-gateway charms in marking OVS bridges and ports as managed by the charm.

The neutron-gateway charm sets `external_ids` to `{charm-neutron-gateway=managed}` for bridges and ports configured and populated by the charm:

$ juju ssh neutron-gateway/2 sudo ovs-vsctl get bridge br-data external_ids
{charm-neutron-gateway=managed}

$ juju ssh neutron-gateway/2 sudo ovs-vsctl get bridge br-int external_ids
{charm-neutron-gateway=managed}

$ juju ssh neutron-gateway/2 sudo ovs-vsctl get interface ens7 external_ids master
{charm-neutron-gateway=br-data}

This behaviour allows the operator to determine which interfaces are managed by the charm and enables further work towards fully managed bridges and ports as discussed in related bug reports [0] and [1].

However, despite very similar configuration options and functionality, this behaviour is currently missing in the neutron-openvswitch charm:

$ juju ssh neutron-openvswitch/0 sudo ovs-vsctl get bridge br-int external_ids
{}

$ juju ssh neutron-openvswitch/0 sudo ovs-vsctl get bridge br-data external_ids
{}

$ juju ssh neutron-openvswitch/0 sudo ovs-vsctl get interface ens7 external_ids
{}

The expected behaviour would be that the neutron-openvswitch charm populates `external_ids` for all bridges and ports that it has configured, e.g.:

$ juju ssh neutron-openvswitch/0 sudo ovs-vsctl get bridge br-int external_ids
{charm-neutron-openvswitch=managed}

$ juju ssh neutron-openvswitch/0 sudo ovs-vsctl get bridge br-data external_ids
{charm-neutron-openvswitch=managed}

$ juju ssh neutron-openvswitch/0 sudo ovs-vsctl get interface ens7 external_ids
{charm-neutron-openvswitch=br-data}

The solution would be to replicate functionality implemented for charm-neutron-gateway in this patchset [2].

[0] https://bugs.launchpad.net/charm-neutron-openvswitch/+bug/1915967
[1] https://bugs.launchpad.net/charm-neutron-gateway/+bug/1809190/
[2] https://review.opendev.org/c/openstack/charm-neutron-gateway/+/717074/

[Przemyslaw Lal (przemeklal)]

Patch available for review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/778458/

[Przemyslaw Lal (przemeklal)]

Patch has been successfully merged by Zuul.