SRIOV init script raises an error: [: Illegal number: 8 eth1:8

[Nicolas Pochet]

When modifying by hand the default environment file (as described in https://bugs.launchpad.net/charm-neutron-openvswitch/+bug/1832378), the /etc/init.d/neutron-openvswitch-networking-sriov.sh script raises the following error:

Jun 11 16:10:26 myhost neutron-openvswitch-networking-sriov.sh[786511]: /etc/init.d/neutron-openvswitch-networking-sriov.sh: 39: [: Illegal number: 8 eth1:8

It is due to https://github.com/openstack/charm-neutron-openvswitch/blob/03eb908d822fcdc91f14c22434a0fd0b51761c90/templates/kilo/neutron-openvswitch-networking-sriov.sh#L50

Stupid bash reproducer:

VFS_LIST="eth0:8 eth1:8"
echo ${VFS_LIST}
eth0:8 eth1:8
echo ${VFS_LIST} | while IFS=':' read DEVICE NUMVFS; do echo "numvfs: ${NUMVFS}, device: ${DEVICE}"; done
numvfs: 8 eth1:8, device: eth0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/665314

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665314
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-openvswitch/commit/?id=d02fad482d328a3368ccdbad8a5f253a774a03cc
Submitter: Zuul
Branch: master

commit d02fad482d328a3368ccdbad8a5f253a774a03cc
Author: Nicolas Pochet <email address hidden>
Date: Fri Jun 14 08:48:09 2019 +0200

    Replace SR-IOV systemd unit script

    * The goal of this change is to enable the ability to configure only the
    VFs that are configured through the charm and not fallback to the
    blanket configuration.
    * This python version of the script brings unit-tests that fully covers
    it.
    * Move the the template files to `files` and modify `neutron_ovs_utils`
    accordingly.

    Closes-Bug: 1832379
    Depends-On: https://review.opendev.org/#/c/664837/

    Change-Id: I7ad1ebc16883bda23cbad89a852e7e8f88f49c49