report_interval and polling_interval not supported in neutron-api

[Yoshi Kadokawa]

When the OpenStack clouds get bigger, more messaging transactions will happen,
which will cause more load on rabbitmq server.
In order to mitigate this, report_interval and polling_interval values are important to adjust accordingly to the size of OpenStack cluster.
However, those values are in [agent] section, which is not configurable with config-flags parameter.

[Hua Zhang (zhhuabj)]

Hi James, Yoshi,

Based on comment in the bug 1685791, I plan to implement the following charm codes, pls review if it's what you want and if I am missing something, thanks.

1, agent_down_time

Just used by neutron-server, so I think config-flags in neutron-api charm has supported it by:

juju set neutron-api config-flags='agent_down_time = 75'

2, polling_interval

Just used by l2 agents, set it in neutron-api charm centrally, then neutron-openvswitch charm gets it via it's relations and set it in [agent] of ml2_conf.ini

3, rpc_response_timeout

Used by all kinds of agents like l2, l3, dhcp, metadata, meter etc, set it in neutron-api charm centrally, then both neutron-openvswitch charm and neutron-gateway charm get it via it's relations and set it in [default] of neutron.conf

4, report_interval

Used by all kinds of agents like l2, l3, dhcp, metadata, metering etc, set it in neutron-api charm centrally, then both neutron-openvswitch charm and neutron-gateway charm get it via it's relations and set it in [agent] of neutron.conf

[Hua Zhang (zhhuabj)]

Some of codes are in charm-helpers repo: https://code.launchpad.net/~zhhuabj/charm-helpers/lp1685788/+merge/326824

Other codes are in the charm neutron-api, neutron-gateway and neutron-openvswitch:

neutron-api: https://review.openstack.org/480342
neutron-gateway: https://review.openstack.org/480344
neutron-openvswitch: https://review.openstack.org/#/c/480345

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/480342
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-api/commit/?id=0e4def19399d0a36d2e67805bc123840f82b9966
Submitter: Jenkins
Branch: master

commit 0e4def19399d0a36d2e67805bc123840f82b9966
Author: Zhang Hua <email address hidden>
Date: Wed Jul 5 10:39:42 2017 +0800

    Support polling-interval rpc-response-timeout and report-interval

    This patch adds support for setting polling-interval rpc-response-timeout
    and report-interval in neutron-api charm centrally, then other charms
    need to continue doing:

    1, polling_interval
       Just used by neutron l2 agents, so neutron-openvswitch charm
       gets it via its relations and set it in [agent] of ml2_conf.ini
       or openvswitch_agent.ini(>=Mitaka)

    2, rpc_response_timeout
       Used by all neutron agents, so both neutron-gateway charm and
       neutron-openvswitch charm get it via its relations and set it
       in [default] of neutron.conf

    3, report_interval
       Used by all neutron agents, so both neutron-gateway charm and
       neutron-openvswitch charm get it via its relations and set it
       in [agent] of neutron.conf

    This patch also syncs charmhelpers.

    Change-Id: I669e959a596b214acf486b0532c4ab31c2b82557
    Partial-Bug: #1685788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/480344
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-gateway/commit/?id=d49b2a18eea1b878b16651c4ff3f789be64f0894
Submitter: Jenkins
Branch: master

commit d49b2a18eea1b878b16651c4ff3f789be64f0894
Author: Zhang Hua <email address hidden>
Date: Wed Jul 5 11:14:08 2017 +0800

    Support setting rpc-response-timeout and report-interval

    These two options are set in neutron-api charm centrally,
    this patch allows neutron-gateway charm to continue doing:

    1, rpc_response_timeout
       Used by all neutron agents, so both neutron-gateway charm and
       neutron-openvswitch charm get it via it's relations and set it
       in [default] of neutron.conf

    2, report_interval
       Used by all neutron agents, so both neutron-gateway charm and
       neutron-openvswitch charm get it via it's relations and set it
       in [agent] of neutron.conf

    This patch also syncs charmhelpers for setting them centrally.

    Change-Id: Ib97418b1aaf55f508cae05f4d7809d79a92a7f6f
    Partial-Bug: #1685788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/480345
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-openvswitch/commit/?id=6b5273f4154d3883cba8b5928da44bd0b5bc5099
Submitter: Jenkins
Branch: master

commit 6b5273f4154d3883cba8b5928da44bd0b5bc5099
Author: Zhang Hua <email address hidden>
Date: Wed Jul 5 11:21:33 2017 +0800

    Support polling-interval rpc-response-timeout and report-interval

    These options are set in the neutron-api charm centrally, and
    this patch allows neutron-openvswitch charm to continue doing:

    1, polling_interval
       Just used by neutron l2 agents, so neutron-openvswitch charm
       gets it via it's relations and set it in [agent] of ml2_conf.ini
       or openvswitch_agent.ini(>=Mitaka)

    2, rpc_response_timeout
       Used by all neutron agents, so both neutron-gateway charm and
       neutron-openvswitch charm get it via it's relations and set it
       in [default] of neutron.conf

    3, report_interval
       Used by all neutron agents, so both neutron-gateway charm and
       neutron-openvswitch charm get it via it's relations and set it
       in [agent] of neutron.conf

    Change-Id: I76c0c75d5f3b4fdd1eb3242b53fde2e829fedca5
    Partial-Bug: #1685788

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/499058

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/499060

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499058
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-openvswitch/commit/?id=4aab943b17cf9ea002e5ea66a2ef2b9520fe35cb
Submitter: Jenkins
Branch: master

commit 4aab943b17cf9ea002e5ea66a2ef2b9520fe35cb
Author: Zhang Hua <email address hidden>
Date: Wed Aug 30 15:19:15 2017 +0800

    Support rpc_response_timeout and report_interval in neutron.conf

    A new mitaka neutron.conf template was introduced into the charm
    lately, so both rpc_response_timeout and report_interval need to
    be set into the template as well.

    Change-Id: I3e049e5366aa3471ce63fea57822e7068e7db5b9
    Partial-Bug: #1685788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499060
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-gateway/commit/?id=3a5a2675b58bf63a2e8902908fc26ef4254ad425
Submitter: Jenkins
Branch: master

commit 3a5a2675b58bf63a2e8902908fc26ef4254ad425
Author: Zhang Hua <email address hidden>
Date: Wed Aug 30 15:25:42 2017 +0800

    Support rpc_response_timeout and report_interval in neutron.conf

    A new mitaka neutron.conf template was introduced into the charm
    lately, so both rpc_response_timeout and report_interval need to
    be set into the template as well.

    Change-Id: I7f34227132d5491d34ff517b8842b21ac5b2991c
    Partial-Bug: #1685788