neutron-api charm should set the state to "blocked" when not related to rabbitmq-server

[Tytus Kurek]

IMHO, neutron-api charm should set the state to "blocked" if not related to rabbitmq-server charm. Currently, the following sequence is sufficient to get the "active" state:

juju deploy neutron-api

juju add-relation neutron-api percona-cluster
juju add-relation neutron-api keystone

Obviously, the relation needs to be added to get the service working.

[Ryan Beisner (1chb1n)]

This bug is about feedback and visibility to the user/operator. I agree with Tytus. But since this bug has been around a while, please exercise a simple reproducer to confirm that this condition still exists.

[Diko Parvanov (dparv)]

Tested and reproduced, issue still exists. Attached screenshot from a simple deployment.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/647515

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/647515
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-api/commit/?id=1ae9774e303fe856ffd1ffc1deba5085223c666f
Submitter: Zuul
Branch: master

commit 1ae9774e303fe856ffd1ffc1deba5085223c666f
Author: Diko Parvanov <email address hidden>
Date: Mon Mar 25 17:41:09 2019 +0200

    Fix charm status when missing amqp relation

    Set charm status to blocked if not related to amqp broker

    Check if context is available in NeutronAMQPContext for existing relation to a
    amqp broker. Modify the context only if it already exists - pointing to charm
    relation already set.

    Closes-Bug: #1726419

    Change-Id: I10dc05567a59bb187d537fb40628e422c77bb864