certs relation failed when no chain info available

[Edward Hope-Morley]

2019-10-30 15:33:43 INFO juju-log Invoking reactive handler: reactive/layer_openstack.py:109:default_configure_certificates
2019-10-30 15:33:44 ERROR juju-log Hook error:
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-neutron-api-plugin-ovn-0/.venv/lib/python3.6/site-packages/charms/reactive/__init__.py", line 74, in main
    bus.dispatch(restricted=restricted_mode)
  File "/var/lib/juju/agents/unit-neutron-api-plugin-ovn-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 390, in dispatch
    _invoke(other_handlers)
  File "/var/lib/juju/agents/unit-neutron-api-plugin-ovn-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 359, in _invoke
    handler.invoke()
  File "/var/lib/juju/agents/unit-neutron-api-plugin-ovn-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 181, in invoke
    self._action(*args)
  File "/var/lib/juju/agents/unit-neutron-api-plugin-ovn-0/charm/reactive/layer_openstack.py", line 119, in default_configure_certificates
    instance.configure_tls(tls)
  File "lib/charm/openstack/neutron_api_plugin_ovn.py", line 62, in configure_tls
    tls_object.get('chain', ''))
TypeError: must be str, not NoneType

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/692176

[Frode Nordahl (fnordahl)]

Thank you for reporting this!

It implies that something is adding 'chain' to that dictionary even when it has a NoneType value, that is mean, we may want to address that as well, but I'm happy to land your fix as-is

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/692176
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-api-plugin-ovn/commit/?id=0b4b89340dbefd9a20e2eb4d2505a4b8675a6db5
Submitter: Zuul
Branch: master

commit 0b4b89340dbefd9a20e2eb4d2505a4b8675a6db5
Author: Edward Hope-Morley <email address hidden>
Date: Wed Oct 30 15:40:42 2019 +0000

    Prevent error if cert has no chain info

    Change-Id: Ib2f52ef63cec268c30ab74f928f4db85677f028a
    Closes-Bug: #1850659

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/692225

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/692226

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/692226
Committed: https://git.openstack.org/cgit/x/charm-ovn-chassis/commit/?id=2117c440e2be5f6987ad487788b24bfd0e56cc92
Submitter: Zuul
Branch: master

commit 2117c440e2be5f6987ad487788b24bfd0e56cc92
Author: Edward Hope-Morley <email address hidden>
Date: Wed Oct 30 21:13:56 2019 +0000

    Prevent error if cert has no chain info

    Change-Id: I84542431f356d5aa70fed3b1f7bcd71a8a70e6e8
    Closes-Bug: #1850659

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/692225
Committed: https://git.openstack.org/cgit/x/charm-ovn-central/commit/?id=54caf36bb8f037dabff74f3a804aecac77b27cb4
Submitter: Zuul
Branch: master

commit 54caf36bb8f037dabff74f3a804aecac77b27cb4
Author: Edward Hope-Morley <email address hidden>
Date: Wed Oct 30 21:15:22 2019 +0000

    Prevent error if cert has no chain info

    Change-Id: I21c3867dd3440cd68bd00959c0744e7eb279de88
    Closes-Bug: #1850659

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/19.10
Review: https://review.opendev.org/692365

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/19.10
Review: https://review.opendev.org/692366

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/19.10
Review: https://review.opendev.org/692367

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/692365
Committed: https://git.openstack.org/cgit/x/charm-ovn-central/commit/?id=1f310bf0b669732514fcf7bf5dc1545cd90adb3c
Submitter: Zuul
Branch: stable/19.10

commit 1f310bf0b669732514fcf7bf5dc1545cd90adb3c
Author: Edward Hope-Morley <email address hidden>
Date: Wed Oct 30 21:15:22 2019 +0000

    Prevent error if cert has no chain info

    Change-Id: I21c3867dd3440cd68bd00959c0744e7eb279de88
    Closes-Bug: #1850659
    (cherry picked from commit 54caf36bb8f037dabff74f3a804aecac77b27cb4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/692366
Committed: https://git.openstack.org/cgit/x/charm-ovn-chassis/commit/?id=db8521452572abadac19386907bac3a6b5c28fa0
Submitter: Zuul
Branch: stable/19.10

commit db8521452572abadac19386907bac3a6b5c28fa0
Author: Edward Hope-Morley <email address hidden>
Date: Wed Oct 30 21:13:56 2019 +0000

    Prevent error if cert has no chain info

    Change-Id: I84542431f356d5aa70fed3b1f7bcd71a8a70e6e8
    Closes-Bug: #1850659
    (cherry picked from commit 2117c440e2be5f6987ad487788b24bfd0e56cc92)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/692367
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-api-plugin-ovn/commit/?id=3b9750c8848d8b1b62169a4a2537384777ab1e93
Submitter: Zuul
Branch: stable/19.10

commit 3b9750c8848d8b1b62169a4a2537384777ab1e93
Author: Edward Hope-Morley <email address hidden>
Date: Wed Oct 30 15:40:42 2019 +0000

    Prevent error if cert has no chain info

    Change-Id: Ib2f52ef63cec268c30ab74f928f4db85677f028a
    Closes-Bug: #1850659
    (cherry picked from commit 0b4b89340dbefd9a20e2eb4d2505a4b8675a6db5)