Functests: Convert amulet tests to Zaza
Bug #1887650 reported by
Alvaro Uria
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Nagios Charm |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
This charm does not have unit tests, and the current functional tests are too old to work. Amulet tests should be rewritten using the Zaza framework (as other LMA charms do).
Related branches
~addyess/charm-nagios:modern_testing
Merged
into
~nagios-charmers/charm-nagios:master
at
revision bb11fd7969e661e47797ec88a98652e74e1d8b30
- Chris Sanders (community): Approve
-
Diff: 1417 lines (+567/-108)23 files modified.gitignore (+3/-1)
Makefile (+29/-12)
dev/null (+0/-56)
hooks/common.py (+1/-1)
hooks/monitors-relation-broken (+1/-1)
hooks/monitors-relation-changed (+1/-0)
hooks/monitors-relation-departed (+1/-1)
hooks/monitors_relation_changed.py (+5/-5)
hooks/upgrade-charm (+1/-0)
hooks/upgrade_charm.py (+6/-3)
hooks/website-relation-joined (+1/-0)
hooks/website_relation_joined.py (+2/-1)
requirements.txt (+2/-0)
tests/functional/conftest.py (+290/-0)
tests/functional/requirements.txt (+5/-0)
tests/functional/test_config.py (+114/-0)
tests/functional/test_deploy.py (+39/-0)
tests/unit/conftest.py (+5/-0)
tests/unit/requirements.txt (+3/-0)
tests/unit/test_common.py (+5/-0)
tests/unit/test_monitor_relation_changed.py (+7/-0)
tests/unit/test_website_relation_joined.py (+19/-0)
tox.ini (+27/-27)
Revision history for this message
| Adam Dyess (addyess) wrote | #1 |
| Changed in charm-nagios: | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| assignee: | nobody → Adam Dyess (addyess) |
| Changed in charm-nagios: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Adam Dyess (addyess) wrote | #2 |
| Changed in charm-nagios: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Adam Dyess (addyess) wrote | #3 |
| Changed in charm-nagios: | |
| milestone: | none → 20.08 |
| assignee: | Adam Dyess (addyess) → nobody |
To post a comment you must log in.
I've started some work towards this though not necessarily in zaza. But at least written as pytest. Maybe a second effort can be put forth to make as zaza tests.