monitors-relation-changed repeats many times and takes a very long time
Bug #1725376 reported by
Xav Paice
This bug affects 6 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Nagios Charm |
Fix Released
|
High
|
Paul Goins | ||
Bug Description
On a setup where we have many nrpe units related to nagios, the monitors-
It would be nice to refactor to make that more efficient.
Related branches
~vultaire/charm-nagios:allow-multiple-relation-data-sets-per-host
- Garrett Neugent (community): Approve
- Xav Paice (community): Approve
- 🤖 prod-jenkaas-bootstack: Approve (continuous-integration)
- BootStack Reviewers: Pending requested
-
Diff: 35 lines (+8/-5)1 file modifiedhooks/monitors_relation_changed.py (+8/-5)
~vultaire/charm-nagios:skip-dedupe-prefix-for-same-model
- Garrett Neugent (community): Approve
- Xav Paice (community): Approve
- 🤖 prod-jenkaas-bootstack: Approve (continuous-integration)
- BootStack Reviewers: Pending requested
-
Diff: 22 lines (+8/-1)1 file modifiedhooks/monitors_relation_changed.py (+8/-1)
~vultaire/charm-nagios:remove-legacy-deduping
- Garrett Neugent (community): Approve
- Xav Paice (community): Approve
- 🤖 prod-jenkaas-bootstack: Approve (continuous-integration)
- BootStack Reviewers: Pending requested
-
Diff: 178 lines (+4/-58)4 files modifiedhooks/common.py (+1/-8)
hooks/monitors_relation_changed.py (+2/-23)
tests/unit/test_common.py (+1/-13)
tests/unit/test_monitor_relation_changed.py (+0/-14)
~vultaire/charm-nagios:speed-optimizations
- Xav Paice (community): Approve
- James Troup (community): Approve
- 🤖 prod-jenkaas-bootstack: Approve (continuous-integration)
- Paul Goins: Abstain
-
Diff: 664 lines (+379/-33)11 files modifiedactions.yaml (+2/-0)
actions/rewrite-peer-config (+1/-0)
actions/rewrite_peer_config.py (+10/-0)
hooks/common.py (+132/-15)
hooks/monitors_relation_changed.py (+63/-14)
hooks/upgrade_charm.py (+2/-2)
tests/unit/requirements.txt (+2/-0)
tests/unit/test_common.py (+123/-0)
tests/unit/test_monitor_relation_changed.py (+39/-1)
tests/unit/test_website_relation_joined.py (+1/-1)
tox.ini (+4/-0)
| Changed in nagios-charm: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| Changed in nagios-charm: | |
| assignee: | nobody → Wouter van Bommel (woutervb) |
| Changed in nagios-charm: | |
| assignee: | Wouter van Bommel (woutervb) → nobody |
| Changed in nagios-charm: | |
| assignee: | nobody → Wouter van Bommel (woutervb) |
| Changed in charm-nagios: | |
| assignee: | Wouter van Bommel (woutervb) → nobody |
| Changed in charm-nagios: | |
| assignee: | nobody → Paul Goins (vultaire) |
| milestone: | none → 21.10 |
| Changed in charm-nagios: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Paul Goins (vultaire) wrote | #1 |
| Changed in charm-nagios: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is immediately available in cs:~llama-