Add support for config tunables

Bug #1941650 reported by Vladimir Grevtsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Masakari Monitors Charm
Fix Released
Wishlist
Zeeshan Ali Shah

Bug Description

Classic charms (nova-cloud-controller, neutron-api etc) have a "config-flags" option. This option would be useful in the masakari-monitors (and
other reactive charms).

config-flags
(string) Comma-separated list of key=value config flags. These values will be placed in the nova.conf [DEFAULT] section.

(gnuoy: I have removed references to the masakari process monitor as that is not supported by the charm and there is no intention to add it. This bug is about adding config-flags config option)

Changed in charm-masakari-monitors:
status: New → Triaged
importance: Undecided → Wishlist
summary: - [new] add support for config tunables
+ Add support for config tunables
tags: added: good-first-bug
Changed in charm-masakari-monitors:
assignee: nobody → Zeeshan Ali Shah (babal1nux)
Revision history for this message
James Page (james-page) wrote :

as a side note - the options referenced relate to process monitoring which is a part of Masakari that the charms project does not enable.

Revision history for this message
Zeeshan Ali Shah (babal1nux) wrote :

Thanks James , please advice me if that is ok

1) i have created config.yaml in charmed masakri monitor
2) now creating @when config changed kind of methods to be called in case config changed
3) how do i actually set the values in masakri itself ? which class should i use ? or any other way to set these values in masakri ?

Liam Young (gnuoy)
description: updated
Changed in charm-masakari-monitors:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-masakari-monitors (master)

Reviewed: https://review.opendev.org/c/openstack/charm-masakari-monitors/+/836011
Committed: https://opendev.org/openstack/charm-masakari-monitors/commit/01679e56a35c6de4977b17f7d792181bab2baafb
Submitter: "Zuul (22348)"
Branch: master

commit 01679e56a35c6de4977b17f7d792181bab2baafb
Author: Zeeshan Ali Shah <email address hidden>
Date: Thu Mar 31 13:05:59 2022 +0500

    Enable multiple arbitrary config-flags

    The config flags are a comma-seperated list of keys and values.
    This enables an operator to pass arbitrary configuration into
    the masakari-monitors configuration.

    Closes-Bug: #1941650
    Change-Id: I3571bf7dfcb092ce5d04f439806e9a25465e16c5

Changed in charm-masakari-monitors:
status: In Progress → Fix Committed
Changed in charm-masakari-monitors:
milestone: none → 22.04
Changed in charm-masakari-monitors:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.