process_list.yaml from the charm has non-deployed services defined

[Vladimir Grevtsev]

From the first look, process_list.yaml has at least three services which are either non-deployed or named in another way:

root@hypervisor-hostname:/var/lib/juju/agents/unit-masakari-monitors-11/charm/templates# for svc in $(grep 'systemctl start' ./process_list.yaml | awk '{print $4}'); do echo "====="; systemctl status $svc --no-pager; done
=====
Unit libvirt-bin.service could not be found.
=====
● nova-compute.service - OpenStack Compute
     Loaded: loaded (/lib/systemd/system/nova-compute.service; enabled; vendor preset: enabled)
     Active: active (running) since Tue 2021-08-24 18:36:19 UTC; 23h ago
   Main PID: 2546834 (nova-compute)
      Tasks: 22 (limit: 629145)
     Memory: 239.4M
     CGroup: /system.slice/nova-compute.service
             └─2546834 /usr/bin/python3 /usr/bin/nova-compute --config-file=/etc/nova/nova.conf --config-file=/etc/nova/nova-compute.conf --log-file=/var/log/nova/nova-comp…

Aug 24 18:36:19 hypervisor-hostname systemd[1]: Started OpenStack Compute.
Aug 24 18:36:20 hypervisor-hostname nova-compute[2546834]: Deprecated: Option "logdir" from group "DEFAULT" is deprecated. Use option "log-dir" from group "DEFAULT".
=====
Unit masakari-instancemonitor.service could not be found.
=====
Unit masakari-hostmonitor.service could not be found.
=====
● ssh.service - OpenBSD Secure Shell server
     Loaded: loaded (/lib/systemd/system/ssh.service; enabled; vendor preset: enabled)
     Active: active (running) since Tue 2021-08-24 12:27:22 UTC; 1 day 5h ago
       Docs: man:sshd(8)
             man:sshd_config(5)
   Main PID: 3529 (sshd)
      Tasks: 1 (limit: 629145)
     Memory: 33.9M
     CGroup: /system.slice/ssh.service
             └─3529 sshd: /usr/sbin/sshd -D [listener] 0 of 10-100 startups

Aug 25 17:49:24 hypervisor-hostname sshd[299555]: Accepted publickey for ubuntu from 10.35.85.193 port 43258 ssh2: RSA SHA256:XoxoAz5ih+NcEzc1ZfcM7EEibnq5lH3j29yrVGG1FJk
Aug 25 17:49:24 hypervisor-hostname sshd[299555]: pam_unix(sshd:session): session opened for user ubuntu by (uid=0)
Aug 25 17:52:36 hypervisor-hostname sshd[338718]: Connection closed by 10.35.85.206 port 38674 [preauth]
Aug 25 17:57:36 hypervisor-hostname sshd[410183]: Connection closed by 10.35.85.206 port 42484 [preauth]
Aug 25 18:02:36 hypervisor-hostname sshd[474930]: Connection closed by 10.35.85.206 port 46290 [preauth]
Aug 25 18:07:36 hypervisor-hostname sshd[536627]: Connection closed by 10.35.85.206 port 50102 [preauth]
Aug 25 18:10:59 hypervisor-hostname sshd[587339]: Connection closed by 10.35.85.193 port 49472 [preauth]
Aug 25 18:10:59 hypervisor-hostname sshd[587358]: Accepted publickey for ubuntu from 10.35.85.193 port 49482 ssh2: RSA SHA256:XoxoAz5ih+NcEzc1ZfcM7EEibnq5lH3j29yrVGG1FJk
Aug 25 18:10:59 hypervisor-hostname sshd[587358]: pam_unix(sshd:session): session opened for user ubuntu by (uid=0)
Aug 25 18:12:36 hypervisor-hostname sshd[604903]: Connection closed by 10.35.85.206 port 53910 [preauth]

[Vladimir Grevtsev (vlgrevtsev)]

valid process names:

# ps -ef | grep monitor | grep masakari
masakar+ 804430 1 0 18:27 ? 00:00:00 /usr/bin/python3 /usr/bin/masakari-hostmonitor --config-file=/etc/masakarimonitors/masakarimonitors.conf --log-file=/var/log/masakarimonitors/masakari-host-monitor.log
masakar+ 804476 1 0 18:27 ? 00:00:00 /usr/bin/python3 /usr/bin/masakari-instancemonitor --config-file=/etc/masakarimonitors/masakarimonitors.conf --log-file=/var/log/masakarimonitors/masakari-instance-monitor.log
root 804486 1 0 18:27 ? 00:00:00 /usr/bin/python3 /usr/bin/privsep-helper --config-file /etc/masakarimonitors/masakarimonitors.conf --privsep_context masakarimonitors.privsep.monitors_priv --privsep_sock_path /tmp/tmpo_6kp71n/privsep.sock
masakar+ 805187 1 0 18:27 ? 00:00:00 /usr/bin/python3 /usr/bin/masakari-processmonitor --config-file=/etc/masakarimonitors/masakarimonitors.conf --log-file=/var/log/masakarimonitors/masakari-process-monitor.log

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-masakari-monitors/+/806042

[Vladimir Grevtsev (vlgrevtsev)]

+ field-medium for MR review

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-masakari-monitors/+/806042
Committed: https://opendev.org/openstack/charm-masakari-monitors/commit/37a22da2fdb665983e08319212e5672618bda794
Submitter: "Zuul (22348)"
Branch: master

commit 37a22da2fdb665983e08319212e5672618bda794
Author: Vladimir Grevtsev <email address hidden>
Date: Wed Aug 25 22:36:27 2021 +0400

    Fixing a Masakari service paths

    Upstream process_list.yaml.sample, which was likely
    a source for the charm version, has slightly different
    binaries paths. This patch provides correct systemd service
    names and binaries locations for the masakari-process-monitor
    service.

    Closes-Bug: #1941644
    Change-Id: Ic209723fe7bfdf030310cf8a3e5607caf6a73853