add config-flags option to manila

Bug #1952320 reported by Arif Ali
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Manila Charm
Fix Committed
Wishlist
Francesco De Simone

Bug Description

As per other charms it would be useful to have config-flags option to the manila, so that extra options can be added without having to do manual changed

Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

Hi Arif

Could you flesh this bug report out a little please? e.g. what options/sections in the config file do you want to update. Do you have an example of how the config-flags option would be used (and the format of the input) and what the charm should do with this?

Thanks.

Changed in charm-manila:
status: New → Incomplete
Revision history for this message
Derek Robertson (rober546) wrote :

Hi Alex,
Arif opened this bug for us.

Would like a config-flags option same as cinder charm which would allow us to add desired options to the DEFAULT section of manila.conf.

This is useful where we want to try out different options but without the need to create a configuration option for every single possible option that would be rarely used by others.

In this specific case, I am interested in changing these values from their defaults:

periodic_interval = 60
periodic_fuzzy_delay = 60
periodic_hooks_interval
report_interval = 10

Background:
We use an Infinidat Infinibox array for NFS/Manila. This has concept of 'network spaces' which means we can create say 100 isolated tenant spaces on the same array. Each one of those spaces is a manila backend - which results in 100 manila-share threads. Each of those has to query the same Infinibox API. If we have manila in HA (say 3 nodes) then thats 3*100 API calls every minute all at same time. We want to prevent manila hitting the Infinibox API so often.

Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

Hi Derek,

Thanks for the clarification and the mini-spec. I'll change this to a wishlist item (from incomplete).

Changed in charm-manila:
status: Incomplete → Triaged
importance: Undecided → Wishlist
tags: added: good-first-bug
Changed in charm-manila:
assignee: nobody → Francesco De Simone (fdesi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (master)
Changed in charm-manila:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila (master)

Reviewed: https://review.opendev.org/c/openstack/charm-manila/+/848483
Committed: https://opendev.org/openstack/charm-manila/commit/f2ab722fe8f6c8083d6b7a0a1d962bf44ff795cc
Submitter: "Zuul (22348)"
Branch: master

commit f2ab722fe8f6c8083d6b7a0a1d962bf44ff795cc
Author: fdesi <email address hidden>
Date: Sat Jul 2 11:05:00 2022 +0200

    Add config-flags option

    As per the bug report, add config-flag paramiter to config.yaml to add desired
    options to the DEFAULT section of manila.conf

    Closes-Bug: #1952320
    Change-Id: If1a314119c59212f4fb885ef9af411d1ab05b1e2

Changed in charm-manila:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.