Version 5.0.0 of python-cinderclient removed v1.client which breaks tests

[Alex Kavanagh]

The removal in python-cinderclient of the v1.client module breaks the tests for this charm; the tests need to be upgraded to use the v2 client.

This bug is a tracking bug; it can be closed (for each related charm) when that charms tests are upgraded to the v2 client.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/685345
Committed: https://git.openstack.org/cgit/openstack/charm-manila/commit/?id=6d6f0910c340afb2675f7aa82de5c34aae389c08
Submitter: Zuul
Branch: master

commit 6d6f0910c340afb2675f7aa82de5c34aae389c08
Author: Chris MacNaughton <email address hidden>
Date: Fri Sep 27 14:40:56 2019 +0200

    Pin -python-cinderclient <5.0.0

    Recently, python-cinderclient released a new version at 5.0.0. This
    removes the v1 client, which the tests currently rely on. This patch
    pins the client in nova-cc until the tests are upgraded.

    Change-Id: I07c9b81eb1b6cc78bf92100b602452acd47da656
    Related-Bug: #1845654

[Felipe Reyes (freyes)]

The manila charm functional test suite was migrated to zaza which uses python-cinderclient<6.0.0[0]. With the current state this bug is no longer valid.

[0] https://github.com/openstack-charmers/zaza-openstack-tests/blob/master/setup.py#L61