charms.reactive RelationBase.from_state(...) has disappeared in 0.6.0*

[Alex Kavanagh]

The upcoming release (0.6.0) of charms.reactive has renamed the 'from_state' class method from the RelationBase to 'from_flag'. This breaks charms.openstack, and probably a few OpenStack reactive charms.

The "probably" replacement is to use charms.reactive.relations.endpoint_from_flag() as the equivalent (and more stable) API call.

A quick search of the code bases on 2017-12-12 indicates:

charms.openstack:

charms_openstack/charm/classes.py
657: amqp_ssl = reactive.RelationBase.from_state('amqp.available.ssl')

charms_openstack/charm/core.py
54: return args + tuple(ri for ri in (reactive.RelationBase.from_state(i)
377: interface = reactive.RelationBase.from_state(state)

charms_openstack/adapters.py
1168: cluster_rel = reactive.RelationBase.from_state('cluster.connected')

And in the charms:

charm-designate/src/reactive/designate_handlers.py
126: cluster = reactive.RelationBase.from_state('cluster.available')
129: dns_backend = reactive.RelationBase.from_state('dns-backend.available')
162: cluster = reactive.RelationBase.from_state('cluster.available')
165: dns_backend = reactive.RelationBase.from_state('dns-backend.available')

charm-barbican/src/actions/actions.py
39: hsm = reactive.RelationBase.from_state('hsm.available')
54: hsm = reactive.RelationBase.from_state('hsm.available')

charm-manila-generic/src/lib/charm/openstack/manila_generic.py
202: manila_plugin = charms.reactive.RelationBase.from_state(

charm-tempest/src/actions/run-tempest.py
16: identity_int = reactive.RelationBase.from_state('identity-admin.available')

charm-manila/src/reactive/manila_handlers.py
108: manila_plugin = charms.reactive.RelationBase.from_state(

charm-manila/unit_tests/test_manila_handlers.py
89: self.patch('charms.reactive.RelationBase.from_state',

[James Page (james-page)]

Reactive charms are not (yet) broken so pushing down to a medium priority.

[Alex Kavanagh (ajkavanagh)]

A recent search shows that this has been overtaken by events. No from_state present in the repo.

[Alex Kavanagh (ajkavanagh)]

A recent search shows that this has been overtaken by events. No from_state present in the charm.

[Liam Young (gnuoy)]

As it stands I think the fix for barbican is pretty trivial as only the actions use the old `from_state`. *But* the functional test coverage is so poor in the barbican charm that I would be reluctant to land the change without improving if first.