Manilaclient errors on share list for API versions <=2.34

[Goutham Pacha Ravi]

http://logs.openstack.org/17/486017/6/check/gate-rally-dsvm-manila-multibackend/8c022c9/rally-plot/results.html.gz#/ManilaShares.create_and_list_share/failures

Rally tests caught this bug in python-manilaclient:

Traceback (most recent call last):
  File "/opt/stack/new/rally/rally/task/runner.py", line 72, in _run_scenario_once
    getattr(scenario_inst, method_name)(**scenario_kwargs)
  File "/opt/stack/new/rally/rally/plugins/openstack/scenarios/manila/shares.py", line 325, in run
    self._list_shares(detailed=detailed)
  File "/opt/stack/new/rally/rally/task/atomic.py", line 86, in func_atomic_actions
    f = func(self, *args, **kwargs)
  File "/opt/stack/new/rally/rally/plugins/openstack/scenarios/manila/utils.py", line 99, in _list_shares
    detailed=detailed, search_opts=search_opts)
  File "/opt/stack/new/python-manilaclient/manilaclient/api_versions.py", line 399, in substitution
    return method.func(obj, *args, **kwargs)
  File "/opt/stack/new/python-manilaclient/manilaclient/v2/shares.py", line 328, in list
    search_opts.pop("export_location", None)
AttributeError: 'NoneType' object has no attribute 'pop'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/488848

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/488848
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=98e0933ca84570b685dcd237cdf35ac3534b5621
Submitter: Jenkins
Branch: master

commit 98e0933ca84570b685dcd237cdf35ac3534b5621
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Jul 28 17:17:36 2017 -0400

    Fix list command when not given search_opts

    Can't pop values out of None.

    Change-Id: I2c62d8bcae4cc4d035fa2bb3aadffb0e1d190751
    Closes-Bug: #1707303

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/488965

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/488965
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=0fa1a034ac9cad2a03791e344cdb8ffc911fe8f4
Submitter: Jenkins
Branch: stable/pike

commit 0fa1a034ac9cad2a03791e344cdb8ffc911fe8f4
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Jul 28 17:17:36 2017 -0400

    Fix list command when not given search_opts

    Can't pop values out of None.

    Change-Id: I2c62d8bcae4cc4d035fa2bb3aadffb0e1d190751
    Closes-Bug: #1707303
    (cherry picked from commit 98e0933ca84570b685dcd237cdf35ac3534b5621)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient 1.17.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient 1.18.0 release.